After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 524640 - Songs are removed from queue too soon
Songs are removed from queue too soon
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Playback
git master
Other Linux
: Normal normal
: 1.0
Assigned To: Aaron Bockover
Banshee Maintainers
Depends on: 526369
Blocks:
 
 
Reported: 2008-03-27 13:48 UTC by Michael Monreal
Modified: 2008-05-02 19:22 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Michael Monreal 2008-03-27 13:48:07 UTC
Add songs to the queue and play. They are removed as soon as they start playback. They should be removed after playing because:

- this way you would have a playback ( |> ) indicator in the queue, which is nice

- it would allow using the current song to build playlists

Also, currently the song is kept in the list when you manually click it, e.g. play a song from the library, add songs to the queue and while the song from the library is still playing, switch to the queue and press the first song. It will play and be kept in the list as long as it plays. As soon as it finishes, both the song and the next are removed (and the next song plays). Removing songs after playback would solve this inconsistency.
Comment 1 Andrew Conkling 2008-04-01 17:07:56 UTC
I can't reproduce the first part on trunk today; is it possible it's been fixed now? Can you test again?
Comment 2 Michael Monreal 2008-04-02 00:04:39 UTC
Just tested it, it's still behaving the same way. You have to do this:

- start playing song A from the library
- add song B and C (for testing, use another artist for those songs) to queue
- wait for A to finish

at this point you expect B to play. 

- The queue gets activated, but A++ plays.
- A++ finishes playback
- B plays and is removed from the queue as soon as it starts
- c plays and is removed from the queue as soon as it starts
Comment 3 Michael Monreal 2008-04-05 18:12:52 UTC
Splitting the second issue out to its own bug (526369) and marking it as a dependency.
Comment 4 Gabriel Burt 2008-05-01 21:30:51 UTC
This is caused by a bug with the PlayerEngine EventChanged event.  It is raised with EndOfStream, which is handled by the PlaybackControllerService which calls Next (), which triggers a StartOfStream event change, before the PlayQueue has a chance to handle the EndOfStream.  Aaron is working on fixing this.
Comment 5 Gabriel Burt 2008-05-02 19:22:35 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.