GNOME Bugzilla – Bug 524625
patch to compile pan with gcc 4.3
Last modified: 2008-07-05 05:53:41 UTC
Here's a patch to pan so it compiles with gcc 4.3, as originally posted on the developer list by Daniel Rahn (OpenSuSE), with a slight modification combining a couple separate patches to the same file at the same place into one, as Gentoo's epatch didn't like it as originally posted. If he bugged it, I don't see it, so I thought I'd do so so it doesn't get lost. Patch to be attached as it doesn't appear I can attach it on original bug filing... Duncan
Created attachment 108106 [details] [review] gcc 4.3 patch for pan The above patch cures the errors, but there's still a lot of warnings about deprecated headers such as what follows. You may wish to clear these while you are at it, and not have to worry about 4.4 so much. There's info in the gcc 4.3 porting guide at http://gcc.gnu.org/gcc-4.3/porting_to.html Here's one of the remaining warnings: In file included from /usr/lib/gcc/x86_64-pc-linux-gnu/4.3.0/include/g++-v4/ext/hash_set:64, from ../../pan/general/quark.h:32, from my-tree.cc:25: /usr/lib/gcc/x86_64-pc-linux-gnu/4.3.0/include/g++-v4/backward/backward_warning.h:32:2: warning: #warning This file includes at least one deprecated or antiquated header which may be removed without further notice at a future date. Please use a non-deprecated interface with equivalent functionality instead. For a listing of replacement headers and interfaces, consult the file backward_warning.h. To disable this warning use -Wno-deprecated.
FWIW, the downstream Gentoo bug, with a slightly different patch it appears, is http://bugs.gentoo.org/show_bug.cgi?id=211670
Confirming the bug and changing the severity to blocker. Hope it gets some attention.
svn revision 342 contains a number of changes along these lines. It's currently building for me on RH9, and I'm not sure which (if any) of the pieces of this patch still need to be applied. Could you do a fresh checkout and see if any of these compile errors (not warnings) persist?
Confirmed FIXED_IN_SVN with r345. =8^) Actually, all four patches Gentoo was carrying against 0.132, my local live-svn ebuild being recently rebased on it, are no longer needed. =8^) Thanks! Duncan