After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 523802 - copy in tasks/memos preview does not work
copy in tasks/memos preview does not work
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: BugBuddyBugs
2.22.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: Milan Crha
Evolution QA team
evolution[kill-bonobo]
: 570474 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-03-22 07:13 UTC by frank
Modified: 2009-11-18 04:28 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
proposed evo patch (14.69 KB, patch)
2009-02-16 16:28 UTC, Milan Crha
committed Details | Review

Description frank 2008-03-22 07:13:58 UTC
copy paste does not work in memos in the regular (non-edit) view. if a memo is visible in the preview pane text can be selected and the cut and copy commands are active and seem to execute, but the paste buffer is empty when using an other application to paste the text (eg. in a text editor). if the memo is opend in the edit view, cut & paste works.
this is a bug: either it works in the preview pane as well or the cut/copy commands are greyed out and not available.


Distribution: Ubuntu 8.04 (hardy)
Gnome Release: 2.22.0 2008-03-17 (Ubuntu)
BugBuddy Version: 2.22.0
Comment 1 Nick Jenkins 2008-09-04 13:25:17 UTC
I can confirm this bug:
In Evolution 2.22.3.1, there is a preview pane for the memos. When a memo is selected, this shows start of the the memo's content. However if you highlight a section of this memo, and then go Edit -> Copy, it does not copy the selected text onto the clipboard. But if you open the memo, highlight the same text, and go Edit -> Copy, then it does work. It would be very helpful if Edit -> Copy also worked in the Memo's preview pane.
Comment 2 Milan Crha 2009-02-16 16:28:33 UTC
Created attachment 128841 [details] [review]
proposed evo patch

for evolution;

Tasks and memos. The bonobo-less version will be different for sure.
Comment 3 Matthew Barnes 2009-02-16 17:33:13 UTC
For sure.  Reminding myself to check this on the branch.
Comment 4 Sebastien Bacher 2009-02-25 15:22:47 UTC
*** Bug 570474 has been marked as a duplicate of this bug. ***
Comment 5 Nick Jenkins 2009-03-02 05:33:00 UTC
Any possibility of a developer review/feedback/comments for the patch attached in comment #2, pretty please?
Comment 6 Srinivasa Ragavan 2009-04-07 07:02:23 UTC
Milan, the patch seems fine to me. But I just want to reduce some work for Matt, by not disturbing the trunk much. If this won't affect the KB stuff much, we can push it. Hope its fine with you &  Matt.
Comment 7 Matthew Barnes 2009-04-07 15:28:40 UTC
It will have to be reworked significantly for the branch, since Milan's patch touches a bunch of Bonobo related stuff.  I'm fine with committing it to trunk though.  Just leave the bug open so I can continue tracking this for myself.
Comment 8 Milan Crha 2009-04-07 17:22:23 UTC
Committed to trunk. Committed revision 37502.
Comment 9 Nick Jenkins 2009-11-10 05:35:44 UTC
Confirmed fixed in 2.28.1 - very nice, it's great to be able to copy from the preview pane, thank you!

Only very minor comment is that it could be nice to have right-clicking on the memo preview pane bring up a context menu, with "copy" and "open memo" as two of the options, plus probably "print..." (currently right-clicking on the memo preview pane doesn't seem to do anything)
Comment 10 Matthew Barnes 2009-11-13 16:34:26 UTC
Implemented all your suggestions and more in:
http://git.gnome.org/cgit/evolution/commit/?id=c5e04ca04066ae2d92d3999626ef91d5d0606cab

This adds useful popup menu options to the contact, task and memo preview panes.  In addition to Nick's suggestions it also adds "Save as [iCalendar|vCard]" and "Select All".

Closing this as FIXED.
Comment 11 Nick Jenkins 2009-11-18 04:28:20 UTC
> Implemented all your suggestions and more in

Thank you, that sounds great! Looking forward to using the right-click in preview mode in 2.30.