After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 523666 - Does not have a composer column added patch for review
Does not have a composer column added patch for review
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: User Interface
git master
Other All
: Normal enhancement
: 1.0
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-03-21 00:57 UTC by Michael Miceli
Modified: 2008-03-21 02:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
The patch that would add a composer tab (1.12 KB, patch)
2008-03-21 00:58 UTC, Michael Miceli 		committed Details | Review

Description Michael Miceli 2008-03-21 00:57:44 UTC 
on the irc I was told everything was in order for a composer tab except for this line of code!

Index: src/Core/Banshee.ThickClient/Banshee.Collection.Gui/TrackListView.cs
===================================================================
--- src/Core/Banshee.ThickClient/Banshee.Collection.Gui/TrackListView.cs        (revision 3495)
+++ src/Core/Banshee.ThickClient/Banshee.Collection.Gui/TrackListView.cs        (working copy)
@@ -69,7 +69,8 @@
                 //new SortableColumn ("Rating", new RatingColumnCell (null, true), 0.15, "Rating"),
                 new SortableColumn (Catalog.GetString ("Last Played"), new ColumnCellDateTime ("LastPlayed", true), 0.15, "LastPlayedStamp"),
                 new SortableColumn (Catalog.GetString ("Date Added"), new ColumnCellDateTime ("DateAdded", true), 0.15, "DateAddedStamp"),
-                new SortableColumn (Catalog.GetString ("Location"), new ColumnCellText ("Uri", true), 0.15, "Uri")
+                new SortableColumn (Catalog.GetString ("Location"), new ColumnCellText ("Uri", true), 0.15, "Uri"),
+                new SortableColumn (Catalog.GetString ("Composer"), new ColumnCellText ("Composer", true), 0.25, "Composer")
             );
             
             column_controller.Load ();
Comment 1 Michael Miceli 2008-03-21 00:58:38 UTC 
Created attachment 107717 [details] [review]
The patch that would add a composer tab

Please review and consider implementing
Comment 2 Gabriel Burt 2008-03-21 01:15:25 UTC 
Committed, thanks!
Comment 3 Andrew Conkling 2008-03-21 02:24:46 UTC 
Bug 365560 remains open waiting on the Composer field in the metadata window.