After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 523533 - e_cal_component_get_recurid_as_string should always return NULL or new allocated string
e_cal_component_get_recurid_as_string should always return NULL or new alloca...
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Calendar
2.22.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
Depends on: 523541
Blocks:
 
 
Reported: 2008-03-20 11:52 UTC by Milan Crha
Modified: 2008-03-27 13:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed eds patch (979 bytes, patch)
2008-03-20 11:54 UTC, Milan Crha 		committed Details | Review

Description Milan Crha 2008-03-20 11:52:54 UTC 
I just noticed that e_cal_component_get_recurid_as_string can return local string instead of new allocated one in some particular case, thus fixing it.
Comment 1 Milan Crha 2008-03-20 11:54:31 UTC 
Created attachment 107670 [details] [review]
proposed eds patch

for evolution-data-server;
Comment 2 Milan Crha 2008-03-20 12:21:10 UTC 
or should it return NULL instead of "0"?
Comment 3 Christian Kellner 2008-03-20 13:04:29 UTC 
Looks good, go ahead and commit. Of course a lot functions must be leaking the rid, otherwise that would have lead to a LOT of leaks. We must fix all those memory leaks. (See bug #523541). Cheers.
Comment 4 Milan Crha 2008-03-20 14:29:31 UTC 
I will wait with this until bug #523541 because one without other can cause more troubles than advantages, as we spoked with gicmo.
Comment 5 Milan Crha 2008-03-27 13:16:28 UTC 
Committed to trunk. Committed revision 8593.