GNOME Bugzilla – Bug 523457
oowriter/bug_450210.py regression tests #1 produces the wrong results.
Last modified: 2008-04-08 20:59:44 UTC
Test 1 of 1 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_450210.py:Press 'o' to open the Open File Chooser EXPECTED: "BRAILLE LINE: 'soffice Application Open Dialog'", " VISIBLE: 'soffice Application Open Dialog', cursor=21", "BRAILLE LINE: 'soffice Application Open Dialog Location: $l'", " VISIBLE: 'Location: $l', cursor=11", "SPEECH OUTPUT: ''", "SPEECH OUTPUT: 'Open Version:'", "SPEECH OUTPUT: ''", "SPEECH OUTPUT: 'Location: text '", ACTUAL: "BRAILLE LINE: 'soffice Application Open Dialog'", " VISIBLE: 'soffice Application Open Dialog', cursor=21", "BRAILLE LINE: 'soffice Application Open Dialog File name: File name: List'", " VISIBLE: 'File name: File name: List', cursor=1", "SPEECH OUTPUT: ''", "SPEECH OUTPUT: 'Open'", "SPEECH OUTPUT: 'File name: combo box'", "SPEECH OUTPUT: 'File name: list'",
With oowriter, under Tools->Options on the General page, there is a section: Open/Save dialogs [ ] Use OpenOffice.org dialogs If this is checked, then when the Open dialog is displayed we get: "BRAILLE LINE: 'soffice Application Open Dialog'", " VISIBLE: 'soffice Application Open Dialog', cursor=21", "BRAILLE LINE: 'soffice Application Open Dialog File name: File name: List'", " VISIBLE: 'File name: File name: List', cursor=1", "SPEECH OUTPUT: ''", "SPEECH OUTPUT: 'Open'", "SPEECH OUTPUT: 'File name: combo box'", "SPEECH OUTPUT: 'File name: list'", If it's not checked, then we get: "BRAILLE LINE: 'soffice Application Open Dialog'", " VISIBLE: 'soffice Application Open Dialog', cursor=21", "BRAILLE LINE: 'soffice Application Open Dialog Location: $l'", " VISIBLE: 'Location: $l', cursor=11", "SPEECH OUTPUT: ''", "SPEECH OUTPUT: 'Open Version:'", "SPEECH OUTPUT: ''", "SPEECH OUTPUT: 'Location: text '", So I have two questions: 1/ Which one do we want? 2/ How do we ensure that we've set it up to be that way?
> 1/ Which one do we want? Checked. If it's not checked, the dialogs are whatever the distro came up with so we'll see differences between Solaris and Ubuntu (and potentially between versions within each distro). > 2/ How do we ensure that we've set it up to be that way? Well, I did a little experiment. This setting seems to live in: ~/.openoffice.org2/user/registry/data/org/openoffice/Office in particular, definitely in Common.xcu and possibly also in Views.xcu (both those files changed at the exact same time as a result of my experiment and contain relevant items). Unlike with Firefox, I have yet to find a way to specify a profile to be used by OOo. (I don't think one exists, but I'd love to be proven wrong on that front). So IMHO, I think the easiest thing to do would be to add this to the list of "thou shalts" for regression testing (which now lives on the RegressionTesting page of our wiki) and tar and feather transgressors. :-)
On http://live.gnome.org/Orca/OpenOffice, it looks like we're making this recommendation: "You should use the OpenOffice dialogs and not the native dialogs. Otherwise, OpenOffice might crash (see http://bugzilla.gnome.org/show_bug.cgi?id=412252). To use the OpenOffice dialogs, select the "Tools -> Options -> OpenOffice.org -> General -> Use OpenOffice.org dialogs" option." So...we should go with that. Has Malte gotten back regarding how we could have a test profile to run with (much like we do with FF)? I just did an experiment while flying in the air at the same time as Joanie and noticed that the Use OpenOffice.org dialogs option is stored in .openoffice.org2/user/registry/data/org/openoffice/Office/Common.xcu under the "Misc" section, but only if the "Use OpenOffice.org dialogs" option is unchecked: <prop oor:name="UseSystemFileDialog" oor:type="xs:boolean"> <value>true</value> </prop> Regarding the default value, I believe the OOo_2.4.0rc6_20080315_Solarisx86_install_en-US.tar.gz I downloaded/installed on my SXDE 01/08 machine had the "Use OpenOffice.org dialogs" option checked. That is, it seems to come configured with what we're telling users to do.
> To use the OpenOffice dialogs, select the "Tools -> Options -> > OpenOffice.org -> General -> Use OpenOffice.org dialogs" option." So how do you actually specify that in a regression test? I can certainly get to that checkbox, but then pressing space is just going to toggle the current behavior. How can wer ensure that it's always set? > So...we should go with that. Has Malte gotten back regarding how we > could have a test profile to run with (much like we do with FF)? Here are the replies I got from Malte (I thought you were cc:'ed, but no matter). ------ Message 1 ------ Hi Rich, I wonder why this should recently have changed. I try to figure out. If it really changed (by intention), there is no way to get the old behavior/defaults. Malte. Rich Burridge wrote, On 24.03.08 18:56: > > Hi Malte, > > > > We've noticed that with the change to latest OpenOffice 2.4-dev (RC6) > > that several of our Orca oowrite and oocalc regression tests are now > > failing. We are seeing that things like the default font have changed, > > plus the auto-capitalization of the first character in a paragraph. > > > > To try to make the results of our regression tests be static, we are > > wondering if there is a default profile (or set of preferences) we can > > use with our OOo tests, that will hopefully make these problems go > > away. > > > > Thanks. > > ------ Message 2 ------ Hi Rich, I have asked my colleagues - nothing should have changed. Maybe it's just an issue with the profile on your machine? Malte. Rich Burridge wrote, On 24.03.08 18:56: > > Hi Malte, > > > > We've noticed that with the change to latest OpenOffice 2.4-dev (RC6) > > that several of our Orca oowrite and oocalc regression tests are now > > failing. We are seeing that things like the default font have changed, > > plus the auto-capitalization of the first character in a paragraph. > > > > To try to make the results of our regression tests be static, we are > > wondering if there is a default profile (or set of preferences) we can > > use with our OOo tests, that will hopefully make these problems go > > away. > > > > Thanks. > > ---- No mention of how to specify a default profile there. ---- > Regarding the default value, I believe the > OOo_2.4.0rc6_20080315_Solarisx86_install_en-US.tar.gz > I downloaded/installed on my SXDE 01/08 machine had the > "Use OpenOffice.org dialogs" option checked. And it did too for the Ubuntu OOo-dev 2.4 (RC6) I downloaded. Perhaps the best thing is to just adjust the regression test results to expect that. If you agree, I'll attach a patch. That is, it seems to come configured with what we're telling users to do.
> That is, it seems to come configured with what we're telling users to do. As long as you use the version from openoffice.org, that is correct. The Ubuntu-ized binary by default does the opposite. There do not seem to be any 64-bit binaries (that I can find anyway) and I haven't built it from source yet. So I have to make the change.
Created attachment 108087 [details] [review] Revision #1. Adjusts regression test output to expect the OpenOffice Open/Save dialogs. Patch not committed yet.
(In reply to comment #4) > > To use the OpenOffice dialogs, select the "Tools -> Options -> > > OpenOffice.org -> General -> Use OpenOffice.org dialogs" option." > > So how do you actually specify that in a regression test? I can certainly > get to that checkbox, but then pressing space is just going to toggle > the current behavior. How can wer ensure that it's always set? If it is set by default in the nightly, I think we're good.
> If it is set by default in the nightly, I think we're good. Okay. Patch committed to SVN trunk then, and moving to '[pending]'. Thanks.
Further reply from Malte: Hi Rich, you can tell OOo to use a different user profile by modifying the bootstraprc file, or via command line -env:UserInstallation For details see http://user.services.openoffice.org/en/forum/viewtopic.php?f=15&t=1525 So you can create/modify the profile as needed, and archive it somehow. --
This one seems better for Will to verify.
As per comment in the team meeting today, closing as FIXED.