After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 523451 - oowriter/bug_385828.py regression tests #1 produces the wrong results.
oowriter/bug_385828.py regression tests #1 produces the wrong results.
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: 2.24.0
Assigned To: Orca Maintainers
Orca Maintainers
Depends on:
Blocks: 523438
 
 
Reported: 2008-03-19 21:17 UTC by Rich Burridge
Modified: 2008-04-04 18:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Revision #1. (1.12 KB, patch)
2008-04-01 17:50 UTC, Rich Burridge
committed Details | Review

Description Rich Burridge 2008-03-19 21:17:46 UTC
Test 1 of 1 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_385828.py:Press 'a' to bring up the Agenda... wizard
EXPECTED:
     "BRAILLE LINE:  'soffice Application aw-5blue (read-only) - OpenOffice.org Writer Frame'",
     "     VISIBLE:  'aw-5blue (read-only) - OpenOffic', cursor=1",
     "BRAILLE LINE:  'soffice Application Agenda Wizard Dialog'",
     "     VISIBLE:  'Agenda Wizard Dialog', cursor=1",
     "BRAILLE LINE:  'soffice Application Agenda Wizard Dialog Agenda Wizard OptionPane Steps Panel Page design $l'",
     "     VISIBLE:  'Page design $l', cursor=1",
     "SPEECH OUTPUT: ''",
     "SPEECH OUTPUT: 'aw-5blue (read-only) - OpenOffice.org Writer frame'",
     "SPEECH OUTPUT: ''",
     "SPEECH OUTPUT: 'Agenda Wizard Please choose the page design for the agenda 1. Page design 2. General information 3. Headings to include 4. Names 5. Agenda items 6. Name and location'",
     "SPEECH OUTPUT: ''",
     "SPEECH OUTPUT: 'Page design label'",
ACTUAL:
     "BRAILLE LINE:  'soffice Application JRE is Defective Alert'",
     "     VISIBLE:  'JRE is Defective Alert', cursor=1",
     "BRAILLE LINE:  'soffice Application JRE is Defective Alert OK Button'",
     "     VISIBLE:  'OK Button', cursor=1",
     "SPEECH OUTPUT: ''",
     "SPEECH OUTPUT: 'JRE is Defective'",
     "SPEECH OUTPUT: ''",
     "SPEECH OUTPUT: 'OK button'",
Comment 1 Rich Burridge 2008-03-25 15:26:40 UTC
> JRE is Defective

I've just tried to install a Java Runtime environment to get this test
to work. I initially tried installing the "sun-java6-bin" and
"sun-java6-jre" packages, but then when I run the test, I get the
following in the terminal window:

$ ./runone.sh ../keystrokes/oowriter/bug_385828.py oowriter 0
starting test application oowriter -norestore ...
[Java framework]sunjavaplugin.so could not load Java runtime library: 
file:///usr/lib/gcj-4.2-81/libjvm.so.

I then installed the "gcj-4.2" package but I'm still getting the
same error.

I've looked at:

http://live.gnome.org/Orca/RegressionTesting

but all it's got is:

"You also apparently need a JRE for the ?OpenOffice tests to work 
(see bug 521651)"

I've looked at that bug but couldn't find anything useful.

What package(s) do I need to install to successfully run this test?
Comment 2 Joanmarie Diggs (IRC: joanie) 2008-03-25 16:41:28 UTC
I'm not sure, but my jre doesn't seem to be defective, and this is everything java that is installed on my laptop:

java-common
java-gcj-compat
java-gcj-compat-headless
libbcel-java
libjaxp1.3-java
libjaxp1.3-java-gcj
libjline-java
liblog4j1.2-java
libmx4j-java
libregexp-java
libxalan2-java
libxalan2-java-gcj
libxerces2-java
libxerces2-java-gcj
openoffice.org-javafilter
sun-java6-bin
sun-java6-jre
sun-java6-plugin
Comment 3 Rich Burridge 2008-03-26 22:51:00 UTC
Thanks Joanie. I think I've now got all of these installed 
and I still can't get the regression test to run (same error
as above). Could somebody else (who has Java working) try this?

Thanks!
Comment 4 Joanmarie Diggs (IRC: joanie) 2008-03-26 23:34:58 UTC
** (soffice:5218): WARNING **: Exception in get_text_at_offset()
Test 1 of 1 FAILED: /home/jd/orca/test/keystrokes/oowriter/bug_385828.py:Press 'a' to bring up the Agenda... wizard
EXPECTED:
     "BRAILLE LINE:  'soffice Application aw-5blue (read-only) - OpenOffice.org Writer Frame'",
     "     VISIBLE:  'aw-5blue (read-only) - OpenOffic', cursor=1",
     "BRAILLE LINE:  'soffice Application Agenda Wizard Dialog'",
     "     VISIBLE:  'Agenda Wizard Dialog', cursor=1",
     "BRAILLE LINE:  'soffice Application Agenda Wizard Dialog Agenda Wizard OptionPane Steps Panel Page design $l'",
     "     VISIBLE:  'Page design $l', cursor=1",
     "SPEECH OUTPUT: ''",
     "SPEECH OUTPUT: 'aw-5blue (read-only) - OpenOffice.org Writer frame'",
     "SPEECH OUTPUT: ''",
     "SPEECH OUTPUT: 'Agenda Wizard Please choose the page design for the agenda 1. Page design 2. General information 3. Headings to include 4. Names 5. Agenda items 6. Name and location'",
     "SPEECH OUTPUT: ''",
     "SPEECH OUTPUT: 'Page design label'",
ACTUAL:
     "BRAILLE LINE:  'soffice Application aw-5blue (read-only) - OpenOffice.org Writer Frame'",
     "     VISIBLE:  'aw-5blue (read-only) - OpenOffic', cursor=1",
     "BRAILLE LINE:  'soffice Application Agenda Wizard Dialog'",
     "     VISIBLE:  'Agenda Wizard Dialog', cursor=1",
     "BRAILLE LINE:  'soffice Application Agenda Wizard Dialog Steps Panel  $l'",
     "     VISIBLE:  '  $l', cursor=1",
     "SPEECH OUTPUT: ''",
     "SPEECH OUTPUT: 'aw-5blue (read-only) - OpenOffice.org Writer frame'",
     "SPEECH OUTPUT: ''",
     "SPEECH OUTPUT: 'Agenda Wizard'",
     "SPEECH OUTPUT: ''",
     "SPEECH OUTPUT: 'Page design label'",
[FAILURE WAS UNEXPECTED]
SUMMARY: 0 SUCCEEDED and 1 FAILED (1 UNEXPECTED) of 1 for /home/jd/orca/test/keystrokes/oowriter/bug_385828.py
Comment 5 Joanmarie Diggs (IRC: joanie) 2008-03-27 01:15:06 UTC
I just tried it on my laptop (clean install of OOo 2.4 RC6).  Same results.

To be honest, I think what we're saying now is a *lot* closer to what we want to be saying (yea!).  The expected results are, I think, far too verbose.  What's relevant when this window first appears is:

1. What the heck are we in? (A: Agenda Wizard)
2. What the heck are we on? (A: Page design label)

Ideally, we could lose the aw-5blue stuff, but that frame seems to get focus for a brief moment before the Agenda Wizard appears, so we're giving an accurate account of what's taking place I guess. :-)

Also ideally, rather than saying "Page design label" (technically correct), I think it might be desirable to preface it with the "1." that immediately precedes it even though technically the "1." is not part of the item with focus.  Visually I see that I'm on a step (step 1).  Hearing the "1" (and seeing it in braille) might convey that a bit better non visually.  Arguably the 1 (and the 2 and the 3 and so on) are labels for the focusable element which follows.  The fact that the focusable element that follows is also a label is... well.... not my fault. ;-)  Point is, if the label were "Name:" and the focusable thing were an entry in which I were expected to type my name, Orca would (hopefully) present "Name: text"/"Name: $l".  I think this is the same thing.... FWIW.

As long as I'm here....

After one manages to tab past the (functional list of) labels/steps to get to where they can make changes, we:

1. Fail to speak the bold label at the top which tells us what we should be doing.  For the "Page design" that's "Please choose the page design for the agenda".  For "General information" it's "Please enter general information for this event."

2. Sometimes speak the thing which gains focus multiple times.  For "Page design" we say "Page design: list blue list item Page design: list".  For General information we say "Date: text Date: text Date: text." 

I haven't progressed any further.  But I'm wondering.... Do we want to update the regression tests so that the output matches reality and close this bug and then perhaps open a new bug related to improving what we present in this wizard??
Comment 6 Rich Burridge 2008-04-01 16:20:27 UTC
I now have Java working with oowriter.

Here's where I was going wrong.

* Startup oowriter and select Tools->Options
* Click on the "Java" entry under OpenOffice.org 
  in the tree menu on the left.

If this is the first time, it will churn away presumably
looking to see what JRE's are available.

After a while, it came back with a single entry that reads:

|     | Vendor                |  Version  |  Features
---------------------------------------------------------          
|     | Sun Microsystems Inc. | 1.6.0_05  |

What is really not clear is that the first column is a radio
button and you need to select it. Once I did that, pressed the
OK button and restarted oowriter, then I could successfully
bring up the Agenda's wizard.

Now that I've shaved that yak, back to the original problem.
Comment 7 Rich Burridge 2008-04-01 16:29:06 UTC
Now I get the following failure:

$ ./runone.sh ../keystrokes/oo writer/bug_385828.py oowriter 0
starting test application oowriter -norestore ...

** (soffice:5235): WARNING **: Exception in get_text_at_offset()
Test 1 of 1 FAILED: ../keystrokes/oowriter/bug_385828.py:Press 'a' to bring up the Agenda... wizard
EXPECTED:
     "BRAILLE LINE:  'soffice Application aw-5blue (read-only) - OpenOffice.org Writer Frame'",
     "     VISIBLE:  'aw-5blue (read-only) - OpenOffic', cursor=1",
     "BRAILLE LINE:  'soffice Application Agenda Wizard Dialog'",
     "     VISIBLE:  'Agenda Wizard Dialog', cursor=1",
     "BRAILLE LINE:  'soffice Application Agenda Wizard Dialog Agenda Wizard OptionPane Steps Panel Page design $l'",
     "     VISIBLE:  'Page design $l', cursor=1",
     "SPEECH OUTPUT: ''",
     "SPEECH OUTPUT: 'aw-5blue (read-only) - OpenOffice.org Writer frame'",
     "SPEECH OUTPUT: ''",
     "SPEECH OUTPUT: 'Agenda Wizard Please choose the page design for the agenda 1. Page design 2. General information 3. Headings to include 4. Names 5. Agenda items 6. Name and location'",
     "SPEECH OUTPUT: ''",
     "SPEECH OUTPUT: 'Page design label'",
ACTUAL:
     "BRAILLE LINE:  'soffice Application aw-5blue (read-only) - OpenOffice.org Writer Frame'",
     "     VISIBLE:  'aw-5blue (read-only) - OpenOffic', cursor=1",
     "BRAILLE LINE:  'soffice Application Agenda Wizard Dialog'",
     "     VISIBLE:  'Agenda Wizard Dialog', cursor=1",
     "BRAILLE LINE:  'soffice Application Agenda Wizard Dialog Steps Panel Page design $l'",
     "     VISIBLE:  'Page design $l', cursor=1",
     "SPEECH OUTPUT: ''",
     "SPEECH OUTPUT: 'aw-5blue (read-only) - OpenOffice.org Writer frame'",
     "SPEECH OUTPUT: ''",
     "SPEECH OUTPUT: 'Agenda Wizard'",
     "SPEECH OUTPUT: ''",
     "SPEECH OUTPUT: 'Page design label'",
[FAILURE WAS UNEXPECTED]
SUMMARY: 0 SUCCEEDED and 1 FAILED (1 UNEXPECTED) of 1 for ../keystrokes/oowriter/bug_385828.py
/usr/bin/orca: line 92:  5209 Killed                  /usr/bin/python -c "import orca.orca; orca.orca.main()" "$ARGS"
./runone.sh: line 187:  5216 Killed                  $APP_NAME $ARGS $PARAMS

The output I find is very hard to easily read. I wonder whether is
can be improved upon. What I end up doing, is creating two files
called "old" and "new", then cutting and pasting the EXPECTED and
the ACTUAL output into them, then doing a "diff -c". Maybe the test
harness should be adjusted to do this.

This now gives:

$ diff -c old new
*** old	2008-04-01 09:23:49.000000000 -0700
--- new	2008-04-01 09:23:58.000000000 -0700
***************
*** 2,12 ****
       "     VISIBLE:  'aw-5blue (read-only) - OpenOffic', cursor=1",
       "BRAILLE LINE:  'soffice Application Agenda Wizard Dialog'",
       "     VISIBLE:  'Agenda Wizard Dialog', cursor=1",
!      "BRAILLE LINE:  'soffice Application Agenda Wizard Dialog Agenda Wizard OptionPane Steps Panel Page design $l'",
       "     VISIBLE:  'Page design $l', cursor=1",
       "SPEECH OUTPUT: ''",
       "SPEECH OUTPUT: 'aw-5blue (read-only) - OpenOffice.org Writer frame'",
       "SPEECH OUTPUT: ''",
!      "SPEECH OUTPUT: 'Agenda Wizard Please choose the page design for the agenda 1. Page design 2. General information 3. Headings to include 4. Names 5. Agenda items 6. Name and location'",
       "SPEECH OUTPUT: ''",
       "SPEECH OUTPUT: 'Page design label'"
--- 2,12 ----
       "     VISIBLE:  'aw-5blue (read-only) - OpenOffic', cursor=1",
       "BRAILLE LINE:  'soffice Application Agenda Wizard Dialog'",
       "     VISIBLE:  'Agenda Wizard Dialog', cursor=1",
!      "BRAILLE LINE:  'soffice Application Agenda Wizard Dialog Steps Panel Page design $l'",
       "     VISIBLE:  'Page design $l', cursor=1",
       "SPEECH OUTPUT: ''",
       "SPEECH OUTPUT: 'aw-5blue (read-only) - OpenOffice.org Writer frame'",
       "SPEECH OUTPUT: ''",
!      "SPEECH OUTPUT: 'Agenda Wizard'",
       "SPEECH OUTPUT: ''",
       "SPEECH OUTPUT: 'Page design label'"

From this we can see that the Braille line component hierarchy has changed
and that the speech output is different. It's a match to Joanie's.

Looks to me like we just need to create a patch to adjusted the expected
output to the new output, agreed?

Comment 8 Willie Walker 2008-04-01 17:19:35 UTC
(In reply to comment #7)
> The output I find is very hard to easily read. I wonder whether is
> can be improved upon. What I end up doing, is creating two files
> called "old" and "new", then cutting and pasting the EXPECTED and
> the ACTUAL output into them, then doing a "diff -c". Maybe the test
> harness should be adjusted to do this.

See bug #525592 and feel free to grab it.  :-)

> Looks to me like we just need to create a patch to adjusted the expected
> output to the new output, agreed?

Looks fine to me.  Thanks!
Comment 9 Rich Burridge 2008-04-01 17:50:02 UTC
Created attachment 108431 [details] [review]
Revision #1.

Thanks. Patch committed to SVN trunk. Moving to "[pending]".
Comment 10 Rich Burridge 2008-04-04 18:35:57 UTC
Thanks Mike. Closing as FIXED.