GNOME Bugzilla – Bug 523443
oowriter/bug_361747.py regression tests #1 through #4 produce the wrong results.
Last modified: 2008-04-04 18:32:32 UTC
Test 1 of 4 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_361747.py:Control-Home to move to start of document EXPECTED: "BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view bold italic normal $l'", " VISIBLE: 'bold italic normal $l', cursor=1", "SPEECH OUTPUT: 'bold italic normal'", ACTUAL: "BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view Bold italic normal $l'", " VISIBLE: 'Bold italic normal $l', cursor=1", "SPEECH OUTPUT: 'Bold italic normal'", Test 2 of 4 FAILED: /home/richb/gnome/orca/trunk/test/keystrokes/oowriter/bug_361747.py:Text information for bold word EXPECTED: "SPEECH OUTPUT: 'size 12'", "SPEECH OUTPUT: 'family-name Times'", "SPEECH OUTPUT: 'bold'", ACTUAL: "SPEECH OUTPUT: 'size 12'", "SPEECH OUTPUT: 'family-name Liberation Serif'", "SPEECH OUTPUT: 'bold'", EXPECTED: "BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view bold italic normal $l'", " VISIBLE: 'bold italic normal $l', cursor=6", "SPEECH OUTPUT: 'italic '", "SPEECH OUTPUT: 'size 12'", "SPEECH OUTPUT: 'family-name Times'", "SPEECH OUTPUT: 'style italic'", ACTUAL: "BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view Bold italic normal $l'", " VISIBLE: 'Bold italic normal $l', cursor=6", "SPEECH OUTPUT: 'italic '", "SPEECH OUTPUT: 'size 12'", "SPEECH OUTPUT: 'family-name Liberation Serif'", "SPEECH OUTPUT: 'style italic'", EXPECTED: "BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view bold italic normal $l'", " VISIBLE: 'bold italic normal $l', cursor=13", "SPEECH OUTPUT: 'normal'", "SPEECH OUTPUT: 'size 12'", "SPEECH OUTPUT: 'family-name Times'", ACTUAL: "BRAILLE LINE: 'soffice Application Untitled2 - OpenOffice.org Writer Frame Untitled2 - OpenOffice.org Writer RootPane ScrollPane Document view Bold italic normal $l'", " VISIBLE: 'Bold italic normal $l', cursor=13", "SPEECH OUTPUT: 'normal'", "SPEECH OUTPUT: 'size 12'", "SPEECH OUTPUT: 'family-name Liberation Serif'",
Created attachment 107927 [details] [review] Revision #1. There were two problems here: 1/ As You type in: Control-b bold Control-b <Space> the "bold" is now automatically changed to "Bold" (presumably because oowriter considers it the start of a sentence. 2/ The default font is now "Liberation Serif" and not "Times". Assuming these changes are acceptable, I've converted the expected regression test output to match. Patch not committed yet.
This change seems fine to me.
> 2/ The default font is now "Liberation Serif" and not "Times". Hmmmm.... On my desktop (the OOo 2.4 rc which comes with Hardy) my font is still Times. On my laptop (OOo 2.4 RC6 from openoffice.org), the font is Times New Roman. I tried setting up symbolic links on my laptop to get the harness to know where to find OOo 2.4, but apparently didn't succeed. (Rich, if you worked out what needs to be done on this front, I'd love to hear it. I can manually start Writer from /usr/lib/openoffice/program/oowriter -- which I think is where the harness is looking for it). Anyhoo, as a result, I've only glanced at the test. That said, I'm not seeing anything that will force the font to be "Liberation Serif." Am I not looking in the right place? Or should that be part of the test, or of the profile?
> I tried setting up symbolic links on my laptop to get the harness to know where > to find OOo 2.4, but apparently didn't succeed. (Rich, if you worked out what > needs to be done on this front, I'd love to hear it. I can manually start > Writer from /usr/lib/openoffice/program/oowriter -- which I think is where the > harness is looking for it). $ cd /usr/bin $ sudo ln -s /opt/openoffice.org2.4/program/scalc oocalc $ sudo ln -s /opt/openoffice.org2.4/program/swriter oowriter
Created attachment 108072 [details] [review] Revision #2. Adjusted the regression test to open an empty document which has FreeSerif as the default font. Adjusted the typed test to use "Bold", "Italic" and "Normal" thus avoiding any auto-capitalization problems. Patch checked into SVN trunk. Moving to "[pending]".
Thanks Mike. Closing as FIXED.