After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 523040 - Fails to create tar archives
Fails to create tar archives
Status: RESOLVED DUPLICATE of bug 487012
Product: file-roller
Classification: Applications
Component: docs
2.22.x
Other Linux
: Normal major
: ---
Assigned To: Maintainers of Gnome user documentation
Maintainers of Gnome user documentation
Depends on:
Blocks:
 
 
Reported: 2008-03-17 20:27 UTC by Sebastian Dröge (slomo)
Modified: 2008-03-31 14:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Sebastian Dröge (slomo) 2008-03-17 20:27:37 UTC 
Hi,
when creating a tar archive file-roller tries to use the append option of tar. In newer version of GNU tar this will let tar exit with a non-zero exit value (but the archive is still created). This confused file-roller.

Debian bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=453096

Possible patch: http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=32;filename=fr-fix-createtar.diff;att=1;bug=453096
Comment 1 Sebastian Dröge (slomo) 2008-03-17 20:28:42 UTC 
Patch for easier reading:

--- a/src/fr-command-tar.c
+++ b/src/fr-command-tar.c
@@ -326,7 +326,9 @@ fr_command_tar_add (FrCommand     *comm,
 		g_free (e_base_dir);
 	}
 
-	if (update)
+	if (!path_is_file (c_tar->uncomp_filename))
+		fr_process_add_arg (comm->process, "-cf");
+	else if (update)
 		fr_process_add_arg (comm->process, "-uf");
 	else
 		fr_process_add_arg (comm->process, "-rf");


This seems to be correct... ok to commit to the 2.20 branch and trunk?
Comment 2 Paolo Bacchilega 2008-03-31 14:28:58 UTC 
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.


*** This bug has been marked as a duplicate of 487012 ***