After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 522285 - Session save files should save digests of window titles
Session save files should save digests of window titles
Status: RESOLVED OBSOLETE
Product: metacity
Classification: Other
Component: general
trunk
Other Linux
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks: 518596
 
 
Reported: 2008-03-13 19:01 UTC by Thomas Thurman
Modified: 2020-11-06 20:05 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Thomas Thurman 2008-03-13 19:01:07 UTC
Session save files should save digests of window titles, and not the window titles themselves.  This is sufficient for matching.  Here's the reason why using plaintext is bad:

$ grep epiphany ~/.metacity/sessions/*.ms
/home/marnanel/.metacity/sessions/1139024473-10078-1512709150.ms:  <window id="117f000001000113897822400000025320007" class="Epiphany" name="epiphany" title="Inter-Client Communication Conventions Manual" role="" type="normal" stacking="2">
/home/marnanel/.metacity/sessions/1139026481-11327-4253752538.ms:  <window id="117f000001000113897822400000025320007" class="Epiphany" name="epiphany" title="Changes made to bug 141425" role="" type="normal" stacking="1">

and so on and on, listing a ton of pages I happened to be looking at when I logged out.  I can imagine that this might cause privacy issues for some.

I am currently working on a suggested first draft of refactoring the way we store session files, and in particular what file formats are most efficient and simple to parse (as partly suggested in bug 518596 and more fully in <http://blogs.gnome.org/metacity/2008/03/08/session-management/>), and I want to bear this in mind.  Changing the directory gives us an opportunity to reconsider the file format, and this is one of the problems I've been considering about the old format.

The major trouble with it is that digest algorithms were only introduced in glib 2.15 (<http://library.gnome.org/devel/glib/2.15/glib-Data-Checksums.html>), and we're currently requiring glib 2.6, which seems a heck of a jump.  Does anyone have any thoughts about whether the advantages here outweigh the disadvantages of requiring 2.15?
Comment 1 Thomas Thurman 2008-03-14 15:03:05 UTC
Compare the new HashKnownHosts feature in openssh.
Comment 2 André Klapper 2020-11-06 20:05:59 UTC
bugzilla.gnome.org is being replaced by gitlab.gnome.org. We are closing all old bug reports in Bugzilla which have not seen updates for many years.

If you can still reproduce this issue in a currently supported version of GNOME (currently that would be 3.38), then please feel free to report it at https://gitlab.gnome.org/GNOME/metacity/-/issues/

Thank you for reporting this issue and we are sorry it could not be fixed.