After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 521269 - fill_mountable_info() allocates with glib and frees with dbus
fill_mountable_info() allocates with glib and frees with dbus
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: client module
unspecified
Other Linux
: Normal critical
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2008-03-08 22:35 UTC by Allen Short
Modified: 2008-03-10 17:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Example of crash (376 bytes, text/plain)
2008-03-08 22:37 UTC, Allen Short
  Details
a patch to use g_free instead (602 bytes, patch)
2008-03-08 22:37 UTC, Allen Short
none Details | Review

Description Allen Short 2008-03-08 22:35:59 UTC
at gdaemonvfs.c:611 dbus_free_string_array() is called on pointers allocated via g_strdup. This has catastrophic results when glib does not use the same malloc as dbus (in particular, when glib has been set up to use boehm gc).
Comment 1 Allen Short 2008-03-08 22:37:16 UTC
Created attachment 106872 [details]
Example of crash

A short program that exhibits the problem.
Comment 2 Allen Short 2008-03-08 22:37:59 UTC
Created attachment 106873 [details] [review]
a patch to use g_free instead
Comment 3 Alexander Larsson 2008-03-10 17:26:51 UTC
2008-03-10  Alexander Larsson  <alexl@redhat.com>

        * client/gdaemonvfs.c:
	Free strings with g_free, not dbus_free (#521269)