After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 520526 - should cancel imap mailbox summary update when closed
should cancel imap mailbox summary update when closed
Status: RESOLVED OBSOLETE
Product: evolution
Classification: Applications
Component: Mailer
2.28.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Milan Crha
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2008-03-05 15:13 UTC by Sebastien Bacher
Modified: 2021-05-19 11:57 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28


Attachments
proposed eds patch (3.65 KB, patch)
2008-03-05 15:50 UTC, Milan Crha
none Details | Review
proposed eds patch ][ (4.97 KB, patch)
2008-03-06 22:26 UTC, Milan Crha
committed Details | Review

Description Sebastien Bacher 2008-03-05 15:13:23 UTC
Using the current 2.21 version, when evolution is scanning for changed messages in an imap mailbox and you close it the interface is unsensitived and the update is not stopped, if you are on a slow connection it might take quite some time to get the update and since the interface is not available you can't switch to offline mode to workaround the issue. That's especially an issue when you get network issues and the update is blocked on timeout
Comment 1 Milan Crha 2008-03-05 15:50:03 UTC
Created attachment 106624 [details] [review]
proposed eds patch

for evolution-data-server;

consider something like this.
Comment 2 Sebastien Bacher 2008-03-06 14:25:20 UTC
the change seems to work in some cases but not always when it's refreshing folders or doing several actions. switching to not-connected works immediatly, could that be used when closing?
Comment 3 Milan Crha 2008-03-06 21:25:24 UTC
Hmm, I found that when forcing offline, mail component calls mail_cancel_all (); which forces cancel for all camel threads. This function is also called in next stage of the quit process, but before that it is waiting to finish its job. Definitely cancel some operations in its middle is not the best thing. (I know, in such operations is cancellation blocked - or should be at least.)

I will rather try to update my patch on IMAP only, I've such a feeling it will be better.
Comment 4 Milan Crha 2008-03-06 22:26:06 UTC
Created attachment 106720 [details] [review]
proposed eds patch ][

for evolution-data-server;

Updated patch, I also found an issue with the last one, the store's connect_lock could stay locked, so fixing this too.

I see one weak point on your workaround, I think, if you do go-offline and your changes in actual folder had not been saved yet, then the next time the summary on the server will be different from the local, hard to say whether the local and/or remote summary was updated at all. (Because it was really canceled in the middle of downloading changes.)

I added something similar to this patch too, though. :)
Comment 5 Matthew Barnes 2008-03-11 00:36:42 UTC
Bumping version to a stable release.
Comment 6 Srinivasa Ragavan 2008-03-27 08:54:31 UTC
Milan, I think anyways the server thing will be downloaded and matched against local, the chances of loss is nill. You can commit to trunk/stable
Comment 7 Milan Crha 2008-03-27 12:13:22 UTC
Committed to trunk. Committed revision 8588.
Committed to gnome-2-22. Committed revision 8589.

Only one note, I committed the updated patch, not the first one you marked as accepted :)
Comment 8 Milan Crha 2008-04-21 19:36:21 UTC
Reopening, I notices that even I quit the application, then it still downloads info of the messages in a folder. It doesn't do that every time, but from time to time it does. For big folders, like +20000 messages it can take unbelievable time to quit. I do quit in time of initial folder update after start.
Comment 9 Jeremy Nickurak 2009-09-30 18:06:15 UTC
Confirming that evolution takes several minutes to exit here, in 2.28.
Comment 10 André Klapper 2021-05-19 11:57:08 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. 
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/Community/GettingInTouch/BugReportingGuidelines
and create a new bug report ticket at
  https://gitlab.gnome.org/GNOME/evolution/-/issues/

Thank you for your understanding and your help.