After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 519931 - Orca does not read certain news feeds correctly.
Orca does not read certain news feeds correctly.
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.21.x
Other All
: Normal normal
: 2.22.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2008-03-02 16:39 UTC by Hermann
Modified: 2008-03-06 19:11 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
proposed patch (885 bytes, patch)
2008-03-03 02:42 UTC, Joanmarie Diggs (IRC: joanie)
none Details | Review

Description Hermann 2008-03-02 16:39:16 UTC
Please describe the problem:
Since version 2.21 of Orca, I cannot read the news feed of the German 
newspaper "Frankfurter Rundschau".
The headlines and the publishing date were displayed, but the overview 
is not readable with the cursor. You need the flat review keys to read 
it.
Note: I read my feeds with FF3.
Till version 2.20.x of Orca everything was OK.
So something must have happened either with Orca, or the additional 
updates of the accessibility software (at-spi, atk and gail) have 
changed something.
Note: All my other feeds are readable, among them other newspapers.



Steps to reproduce:
1. Open FF3
2. go for example to: 
http://www.fr-online.de/rss/nachrichten/index.xml
3. Read the feed by using the cursor keys.
You will find the overview lines empty. Use the flat review keys, and 
you can read them.


Actual results:
You will find, that you cannot read the feed properly.


Expected results:
That the feed is displayed correctly, so you can easily read through the 
page using the cursor keys.


Does this happen every time?
It's reproducable.


Other information:
Comment 1 Joanmarie Diggs (IRC: joanie) 2008-03-02 21:27:53 UTC
Confirmed.  We're getting hung up on the large images on the same line at beginning of each story (which are probably not present on your other feeds). :-( Let me see what I can figure out.  Thanks for the report!
Comment 2 Joanmarie Diggs (IRC: joanie) 2008-03-03 02:42:19 UTC
Created attachment 106443 [details] [review]
proposed patch

This patch seems to solve the reported problem along with another one (see our wacky nested table regression test).  

In terms of the other regression tests, there is one difference:  On the bugzilla related pages, we currently treat "Home link image bugzilla" as one line and "New bug link" through "log out link" as being on a separate line.  
With this patch, we treat it all as one line.  Looking at it visually, the home link image is tall and thus on the same line as Bugzilla and as the line of links which begins with New Bug.  So, arguably, this current treatment is a bug which is being fixed. :-)  Still, I'd like input on that one.

Given that this is, as Hermann pointed out, a regression from 2-20, it would be nice to check in a fix in time for 2-22 (code freeze in less than 24 hours if I'm calculating my UTC correctly). Mike, how do you feel about our treating the bugzilla stuff as being on one line?  Also, please test.  Thanks!

(already pylinted)
Comment 3 Mike Pedersen 2008-03-03 03:19:23 UTC
In private chat Joanie just described the appearance of the bugzilla line in question.  Now that I know what it looks like I think the new presentation is correct.  
Comment 4 Mike Pedersen 2008-03-03 03:41:05 UTC
Just tested this.  WOrks great! thanks much
Comment 5 Joanmarie Diggs (IRC: joanie) 2008-03-03 05:54:04 UTC
I found another example where an image spans multiple lines of text (the FrankfurterRundschau FR-online.de image on Hermann's feed site spans the line for the FR - Politik heading 1 and the FR - Politik heading 2).  We may have to become more clever about what do do when it comes to presenting such content.  Rather than hold off on fixing the feed bug until such cleverness strikes me...

Hermann, the patch has been committed both to the gnome-2-22 branch as well as to trunk.  That should solve your immediate problem hopefully.

I opened bug 520029 so that when cleverness strikes w.r.t. the multi-line images I have a patch to which to attach the results. :-)

Moving to pending.
Comment 6 Hermann 2008-03-03 10:39:24 UTC
It's OK, I can read my news feeds again, thanks to Joanie!
I cannot figure out what's wrong with headings 1 and 2 on the side, I 
use to skip them by pressing 3 to move to the first story.
But I noticed that Orca gets stuck on that bar asking to subscribe the 
feed using one of several external apps or use dynamic bookmarks.
Perhaps a problem for a person, who doesn't know this feed very well; I 
now know it by heart :-)
Comment 7 Mike Pedersen 2008-03-06 17:53:00 UTC
As this patch does fix the reported problem I'm verifying this bug.  I do see the behavior Hermann is reporting with moving to heading level 3 when the page first loads.  This is because focus is actually on a combobox.  If you move focus away from the combobox and into the HTML content heading navigation seems to work fine.