GNOME Bugzilla – Bug 519092
Add accessibility support to GtkVolumeButton
Last modified: 2008-06-13 02:32:26 UTC
The GtkVolumeButton is a newer widget for GTK+ and we need accessibility support created for it.
I claim this task ;)
Go for it! A good place to get started with checking things out would be the Accerciser application and Orca. There are some recent Linux Journal articles that tell you how to get going with both of these: http://www.linuxjournal.com/article/9978 http://www.linuxjournal.com/article/9991 In addition, if you know of an application that uses this widget, please let us know so we can work on adding tests for it to the Orca regression test suite.
Created attachment 107328 [details] [review] initial approach Here is an initial draft. Please tell me if I am in the right direction. As GtkVolumeButton is a descendant of GtkScaleButton, some work needs to be done there. So, after this, I'd like to work on bug #519090. I have tested it with accerciser and orca. Also, I just found one app which is using it, brasero.
Li - do you have tim toe lend your expertise in this space to do a quick review?
FWIW the patch looks good to me although I'm that familiar with atk_action_set_description. Is the index 1 based or 0 based?
Hi, David. The index is 0-based, but the action 0 (button click) does nothing. The actual action happens on index 1 (button press), so, I just set the description in that action.
Looks good. Is the press action the only action we need to implement A11Y for VolumeButton? I think we may need click and release actions also.
Hi, Li. In accerciser, in the actions section, the only action which responded to the 'test action' button was 'press'. Click and Release do nothing. What am I supposed to do? Could you give me a tip? Thanks.
Hi Jonh, Do you mean "Interface Viewer"? For a button, it should have 3 actions. Or you can try gok to grab the button.
Hi, Li. Yes, I mean "interface viewer". The button has 3 actions, but only the 'press' action works, by showing the volume control. Must the other actions have descriptions too? Even if they do nothing when executed?
I don't think description is necessary. "works" means you can change the volume by the action?
Yes, it actually shows the control (the scale widget) which you can change the volume.
The patch looks good to me, fwiw.
This patch is really useful could this go to gtk+ 2.13 ?
* gtk/gtkvolumebutton.c: Set accessibility descriptions. Patch by Jonh Wendell