GNOME Bugzilla – Bug 518662
Allow url copy in download manager
Last modified: 2012-07-31 15:49:05 UTC
Epiphany's download manager should perhaps add a right-click option that copies the selected url to the clipboard Other information:
Can you describe a use case for your suggestion? When and why does a typical user need to get the download's URL from the download manager?
Some download sites use <button> to activate downloads, which means you can't copy the url and then use wget or your preferred download manager. Others require that you fill a captcha first, also making it impossible to use wget. A typical user might not need this, but any user on a flaky link will find this useful, since wget works better (being able to resume, and automatically retries the downloads) for downloading big files over slow links.
An example is the download page of BerkeleyDB in the oracle.com site
Created attachment 117942 [details] [review] [PATCH] Add a "Copy Download Address" menu item. embed/downloader-view.c | 95 +++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 95 insertions(+), 0 deletions(-)
+ clipboard = gtk_clipboard_get (GDK_SELECTION_CLIPBOARD); Needs to use the download manager/menu item's display's clipboard, not the default display's. With that fixed, ok to commit after branch.
(In reply to comment #5 by chpe) > With that fixed, ok to commit after branch. Epiphany has branched. Please commit soon before under freeze again.
Not that urgent, since trunk has no downloader right now (webkit doesn't support it yet), and 2-24 is frozen. Either we don't take this for 2.26, or we need to create a gnome-2-26 branch off of the gnome-2-24 branch.
Can it not be committed for at least the gecko backend?
The 2.24.3 tarballs are due today. @Christian, do you think we can roll a 2.24.3 with this patch included?
They were due yesterday, and already done. And 2-24 is UI + string frozen anyway. If we do want this for 2.26, we need to branch. Should we?
I suggest it should be branched. This feature is quite useful, and I often launch firefox just so I can copy a file's download URL.
+ clipboard = gtk_clipboard_get (GDK_SELECTION_CLIPBOARD); + gtk_clipboard_set_text (clipboard, source, -1); Use gtk_widget_get_clipboard () here. + /* free the string anyway when the menu is deactivated */ + g_signal_connect_swapped (menu, "selection-done", + G_CALLBACK (g_free), source); Don't do this. + g_signal_connect (menu_item, "activate", + G_CALLBACK (copy_download_address_activate_cb), source); + g_signal_connect_data with g_free as destroy notify, or else you leak the string. Ok to commit to gnome-2-26 and trunk with these fixed.
I'm afraid this is bug is obsolete -- one can copy the url from the context menu in a link. And there is no Downloads manager.