GNOME Bugzilla – Bug 518075
Sound plugin should start pulseaudio itself
Last modified: 2008-02-28 18:15:55 UTC
This would mean there's no races with gnome-session about starting the sound server, and gnome-settings-daemon would be able to cache the samples properly. It also means that sound effects would just work in GDM.
Created attachment 106173 [details] [review] gsd-launch-esd.patch Launch esd ourselves. I'm pretty sure the sample reloading is broken. We launch esd/pulseaudio even if we're not using esd support, as we need a sound server to put the samples in.
Doesn't building without esd support simply mean that you *don't* have a sample cache (and as such no sound effects)? In any case, I'd much prefer making esd not being available a warning instead of a fatal error. Just use a default path, and if it's not there, launching it will fail, but so what.
I'd like to think that building without esd means that we don't use esd itself (and the crappy quirks that go with it, such as the standby mode). If people don't want sound, they can use the GConf key, or build libgnome without esd support (which is just stubs iirc). I've downgraded the inability to launch esd to a g_printerr(), so we don't crash if esd can't be launched.
2008-02-28 Bastien Nocera <hadess@hadess.net> * plugins/sound/gsd-sound-manager.c (reset_esd_pid), (start_gnome_sound), (stop_gnome_sound), (apply_settings), (gsd_sound_manager_stop): Start the sound server ourselves, as we need it to cache samples. If esd (or the PulseAudio esd compat bits) isn't available, just print an error, and don't try to cache the samples If you use PulseAudio instead of esound in your distribution, build with --disable-esd passed to configure (Closes: #518075)