GNOME Bugzilla – Bug 517896
PATCH: fix building of mpeg2enc plugin with even newer mjpegtools
Last modified: 2008-02-22 06:11:30 UTC
Subject says it all, this patch fixes the building of the mpeg2enc plugin with the latest mjpegtools.
Created attachment 105706 [details] [review] this patch fixes the building of the mpeg2enc plugin with the latest mjpegtools
That only works with latest mjpegtools though, right? Also, the version from gst-plugins-bad 0.10.6 should at least build with latest mjpegtools. What's the error? (and the patch is of course correct, better than the hack in 0.10.6)
(In reply to comment #2) > That only works with latest mjpegtools though, right? > > Also, the version from gst-plugins-bad 0.10.6 should at least build with latest > mjpegtools. What's the error? > > (and the patch is of course correct, better than the hack in 0.10.6) > While updating the livna package to gst-plugins-bad 0.10.6 I noticed that I had forgot to send this patch (originally done against 0.10.5) upstream, so I did that now, as it still applied, I assumed that the plugin would still not build with the latest mjpegtools, sorry for the confusion.
Could you check if it does build? Also, do you know when mjpeg_loglev_t() was added to mjpegtools?
(In reply to comment #4) > Could you check if it does build? > Will do, but this will take some time as I'm going to fosdem this weekend, and probably won't get around to this tomorrow. Are any gstreamer devs going to fosdem? > Also, do you know when mjpeg_loglev_t() was added to mjpegtools? > I _think_ between 1.9.0rc2 and 1.9.0rc3 p.s. Sorry for tagging this onto this bug, but sofar it has seen very little attention. I've (painstakingly) written patches for gstreamer adding seeking of mms streams (which is a really nice feature to have), these patches have been caried in the livna packages for quite a while now without any problems, theyu have been submitted under bug 469930.
I have the mms seeking patch on my TODO list, don't worry :)
Whatever, it's properly fixed in CVS now and uses mjpeg_loglev_t(). 2008-02-22 Sebastian Dröge <slomo@circular-chaos.org> Based on a patch by: Hans de Goede <j dot w dot r dot degoede at hhs dot nl> * configure.ac: * ext/mpeg2enc/gstmpeg2enc.cc: Remove hack to work with mjpegtools 1.9.0rc3 and above and instead use mjpeg_loglev_t() for getting the log levels. Check for this function in configure.ac as the pkg-config file doesn't tell us which release candidate we have. Fixes bug #517896.