After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 517559 - Need to support Gtk*Store definitions in GTKUI files
Need to support Gtk*Store definitions in GTKUI files
Status: RESOLVED FIXED
Product: intltool
Classification: Deprecated
Component: general
0.37.x
Other Linux
: High major
: ---
Assigned To: intltool maintainers
intltool maintainers
Depends on: 518642
Blocks:
 
 
Reported: 2008-02-19 22:22 UTC by Sebastien Bacher
Modified: 2008-03-02 01:52 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Sebastien Bacher 2008-02-19 22:22:09 UTC
The bug has been opened on https://bugs.launchpad.net/bugs/193020

"Binary package hint: totem

There are some strings that can't be translated via Launchpad, because they aren't in the template. The strings are:

- "_Sidebar"
- "Automatically _load subtitle files when movie is loaded"
- " _Allow the screensaver to activate even when audio-only is playing"
- "14.4 Kbps Modem"
- "19.2 Kbps Modem"
- "28.8 Kbps Modem"
- "33.6 Kbps Modem"
- "56 Kbps Modem/ISDN"
- "112 Kbps Dual ISDN/DSL"
- "256 Kbps DSL/Cable"
- "384 Kbps DSL/Cable"
- "512 Kbps DSL/Cable"
- "1.5 Mbps T1/Intranet/LAN"
- "Intranet/LAN"
- "Normal"
- "Large"
- "Extra Large"
- "Stereo"
- "4-channel"
- "4.1-channel"
- "5.0-channel"
- "5.1-channel"
- "AC3 Passthrough"

You can see that those strings aren't in the Spanish template, which is fully translated:

https://translations.launchpad.net/ubuntu/hardy/+source/totem/+pots/totem/es/+translate

For now, there's no new .pot files pending upload into Launchpad:

https://translations.launchpad.net/ubuntu/hardy/+source/totem/+imports?field.filter_status=all&field.filter_extension=pot"

You can try using totem.ui in the current tarball version
Comment 1 Rodney Dawes 2008-02-24 22:12:08 UTC
Is this not a duplicate of bug #454894 ? Or is the pot file just not up-to-date? Translation of gtkui files should work with the glade parsing in intltool, which totem is already set up to use...
Comment 2 Sebastien Bacher 2008-02-25 09:47:28 UTC
the issue is not the same one, when using the gettext glade option and running intltool-update those strings are not listed
Comment 3 Rodney Dawes 2008-02-25 15:28:09 UTC
#: ../data/totem.ui.h:113
msgid "_Sidebar"
msgstr ""

How are they not showing up for you? They are in totem.pot here...
Comment 4 Rodney Dawes 2008-02-25 15:33:13 UTC
OK. I take that back. Some of them show up. It appears gtkui allows defining GtkListStore rows/columns, and glade did not, so there are some missing strings due to that. Changing the summary to reflect that.
Comment 5 Rodney Dawes 2008-02-25 18:16:15 UTC
This should be fixed in SVN now. I've added the col tag to the list of tags to extract translatable strings from.
Comment 6 Johan (not receiving bugmail) Dahlin 2008-03-02 01:23:30 UTC
I'm reopening, since Gtk+ now support translatable/context/comment attributes which makes the solution here insufficient.

Not all data specified in a GtkListStore is per definition translatable, numbers and pixbufs are two good examples of that.

Released versions of GtkBuilder will not translate the strings at all, application authors are on their own, which means that they would have to iterate over all values in the liststore and filter them though gettext() manually.

Intltool should be changed to only pickup translatable strings in <col> tags if the translatable attribute is set to yes. Similar to what is done for <property> tags.
Comment 7 Rodney Dawes 2008-03-02 01:52:47 UTC
It already does this as the same check is used for <property> and <col>. If you look at the regex in the code it checks for the translatable attribute being "yes" as well.

    while ($input =~ /<(property|atkproperty|col)\s+[^>]*translatable\s*=\s*"yes"(?:\s+[^>]*comments\s*=\s*"([^"]*)")?[^>]*>([^<]+)<\/\1>/sg)