GNOME Bugzilla – Bug 517527
Ability to connect to unix domain sockets
Last modified: 2021-05-26 09:24:55 UTC
Forwarded from Debian Bug #466548 http://bugs.debian.org/466548 """Kvm/qemu support starting a VNC server on a unix domain socket. It would be awesome if vinagre could connect to such VNC servers.""" Fast chat on IRC: 15:37 < pochu> jwendell: hi there! I've just got this wishlist in Debian, Debian bug #466548 15:37 < ubotu> Debian bug 466548 in vinagre "Ability to connect to unix domain sockets" [Wishlist,Open] http://bugs.debian.org/466548 15:37 < pochu> Would that be feasible? 15:38 < jwendell> pochu, it's already possible, we just need to change some bits in the connection dialog 15:39 < jwendell> pochu, forward the bug to the gnome bugzilla please Perhaps changing the connection dialog needs an UI freeze... unless this is delayed to 2.24 of course :-) Regards, Emilio
Created attachment 127312 [details] [review] Patch to add ability to connect to Unix domain sockets Hi, here is a patch which implements this request. This is still missing bookmark related code to Unix domain sockets, but otherwise it seems to work. Connection dialog requires now more space, so I don't know if it good this way or is there better way to layout this dialog. I've tested it shortly with my KVM virtual machine, and I got some crashes when reconnecting to same machine without disconnecting first, is there known problems in such scenarios, or is it caused by my modifications? Also any feedback about patch is welcome. Let's see if I find time soon to finish this bookmark thing, but if anyone is willing to do this, you are welcome to continue from where I left.
Is this connected to https://bugs.launchpad.net/vinagre/+bug/330730 ? That's why the screen is "rubbish"? http://launchpadlibrarian.net/26275718/Screenshot%20of%20savvas%27s%20remote%20desktop%20on%20savvas-desktop.png
I'd prefer to do this though Open File dialog...
Comment on attachment 127312 [details] [review] Patch to add ability to connect to Unix domain sockets This will need to be rewritten to take into account the large changes in Vinagre since 2009. The bookmark support will need to be completed before I can accept the patch for merging. The general implementation of the patch seems OK, although it would be good to find a more elegant solution than having another entry for the socket location, as I doubt that most users will know what a unix domain socket is.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version of Vinagre, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new enhancement request ticket at https://gitlab.gnome.org/GNOME/vinagre/-/issues/ Thank you for your understanding and your help.