After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 517420 - typefind: add h264 elementary stream discovery
typefind: add h264 elementary stream discovery
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-19 11:25 UTC by Josep Torra Valles
Modified: 2008-02-19 11:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to perform the typefinding (3.14 KB, patch)
2008-02-19 11:25 UTC, Josep Torra Valles
committed Details | Review

Description Josep Torra Valles 2008-02-19 11:25:00 UTC
Following this I provide a patch to perform h264 elementary stream discovery.

Tested with the following clips.

http://samples.mplayerhq.hu/V-codecs/h264/moonlight.264
http://samples.mplayerhq.hu/V-codecs/h264/nature_704x576_25Hz_1500kbits.h264
Comment 1 Josep Torra Valles 2008-02-19 11:25:58 UTC
Created attachment 105573 [details] [review]
Patch to perform the typefinding
Comment 2 Sebastian Dröge (slomo) 2008-02-19 11:44:16 UTC
Ok, thanks... committed with the small change, that I moved the "if" from outside the loop inside to get the detection a bit faster if it succeeded before already.

2008-02-19  Sebastian Dröge  <slomo@circular-chaos.org>

        Patch by: Josep Torra Valles <josep at fluendo dot com>

        * gst/typefind/gsttypefindfunctions.c: (h264_video_type_find),
        (plugin_init):
        Add typefinding support for h264 elementary streams.
        Fixes bug #517420.