After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 517336 - Spaces interfere with Orca's ability to get the line contents
Spaces interfere with Orca's ability to get the line contents
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.21.x
Other All
: Normal normal
: 2.22.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2008-02-18 22:40 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2008-07-22 19:33 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
revision 1 (608 bytes, patch)
2008-02-24 20:50 UTC, Joanmarie Diggs (IRC: joanie)
none Details | Review
more pythonic version (599 bytes, patch)
2008-02-24 20:53 UTC, Joanmarie Diggs (IRC: joanie)
committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2008-02-18 22:40:54 UTC
When reading a table by line (as opposed to Orca's table navigation commands), we sometimes pick up the text from previous cells.

Example 1:  View the list of bugs in bugzilla being sure that the patch icon appears below the bug number (and hence the cell contains two lines).  When you press Down Arrow, you'll land in the second cell and hear the remainder of the line (which I assume is the expected/desired behavior), but Orca will also speak the first cell.

Example 2:  From Javier:

Browsing the http://live.gnome.org/TwoPointTwentyone
some information in some lines seems to don't appear.

1. Open http://live.gnome.org/TwoPointTwentyone
2. Go to the first table by pressing t 
3. Read by line 

Some dates are not read.
E.G february 11
Only february GNOME is read.
Comment 1 Joanmarie Diggs (IRC: joanie) 2008-02-24 20:42:16 UTC
This is a bigger issue than mere tables.  We're getting thrown off by the presence of a space.  Patch to follow.
Comment 2 Joanmarie Diggs (IRC: joanie) 2008-02-24 20:50:05 UTC
Created attachment 105868 [details] [review]
revision 1

This patch seems to solve a number of problems I've been seeing in terms of knowing when we're done getting the line contents.

Pylinted already.  Still need to run the regression tests (which I'll start now).  In the meantime, please test.
Comment 3 Joanmarie Diggs (IRC: joanie) 2008-02-24 20:53:07 UTC
Created attachment 105870 [details] [review]
more pythonic version
Comment 4 Joanmarie Diggs (IRC: joanie) 2008-02-24 23:41:45 UTC
Just ran the regression tests.  No regressions and it had the unexpected benefit of removing some extra (unwanted) whitespace. Yea!
Comment 5 Mike Pedersen 2008-02-25 00:25:26 UTC
I just tested this one on a bunch of sites and it seems good.  
Comment 6 Joanmarie Diggs (IRC: joanie) 2008-02-25 05:14:14 UTC
Thanks Mike.  Patch (and updated regression tests) committed.  Moving to pending.