After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 517103 - LocalCoverArtSearch returns path without URI scheme for images
LocalCoverArtSearch returns path without URI scheme for images
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
0.11.x
Other All
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-17 23:45 UTC by Jaap-Jan van der Veen
Modified: 2008-03-18 10:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Jaap-Jan van der Veen 2008-02-17 23:45:10 UTC 
Please describe the problem:
I added some debugging info to get_best_match_urls(). First is what currently happens in Rhythmbox (the last line is 'yield self.uri.parent.append_file_name (f_name).path')

(23:56:26) [0x6c9500] [LocalCoverArtSearch.search] LocalCoverArtSearch.py:108: searching for art local to
(23:56:26) [0x6c9500] [LocalCoverArtSearch.search] LocalCoverArtSearch.py:108:  
(23:56:26) [0x6c9500] [LocalCoverArtSearch.search] LocalCoverArtSearch.py:108: smb://gandalf/music/Albums/Therion/2004a%20-%20Sirius%20B/Therion%20-%20Sirius%20B%20-%2008%20-%20Melek%20Taus.mp3
(23:56:26) [0x6c9500] [LocalCoverArtSearch.get_best_match_urls] LocalCoverArtSearch.py:137: file
(23:56:26) [0x6c9500] [LocalCoverArtSearch.get_best_match_urls] LocalCoverArtSearch.py:137:  
(23:56:26) [0x6c9500] [LocalCoverArtSearch.get_best_match_urls] LocalCoverArtSearch.py:137: /music/Albums/Therion/2004a%20-%20Sirius%20B/folder.jpg

And this is what it should be ('yield self.uri.parent.append_file_name (f_name)')

(00:08:18) [0x6c9500] [LocalCoverArtSearch.search] LocalCoverArtSearch.py:108: searching for art local to
(00:08:18) [0x6c9500] [LocalCoverArtSearch.search] LocalCoverArtSearch.py:108:  
(00:08:18) [0x6c9500] [LocalCoverArtSearch.search] LocalCoverArtSearch.py:108: smb://gandalf/music/Albums/Therion/2004a%20-%20Sirius%20B/Therion%20-%20Sirius%20B%20-%2010%20-%20Sirius%20B.mp3
(00:08:18) [0x6c9500] [LocalCoverArtSearch.get_best_match_urls] LocalCoverArtSearch.py:137: file
(00:08:18) [0x6c9500] [LocalCoverArtSearch.get_best_match_urls] LocalCoverArtSearch.py:137:  
(00:08:18) [0x6c9500] [LocalCoverArtSearch.get_best_match_urls] LocalCoverArtSearch.py:137: smb://gandalf/music/Albums/Therion/2004a%20-%20Sirius%20B/folder.jpg

Steps to reproduce:
1. Add 'print self.uri.parent.append_file_name (f_name).path' just above the last line of get_best_match_urls() in LocalCoverSearch.py and recompile with py_compilefiles
2. Start Rhythmbox with 'rhythmbox -D LocalCoverArtSearch&'
3. Play some music on a Samba share with a folder which contains a folder.jpg or other valid cover file
3. See that a wrong file name is generated


Actual results:
You will see that the filename is wrong, it's something like:
/music/Albums/Therion/2004a%20-%20Sirius%20B/folder.jpg

Expected results:
But it should be something like:
smb://gandalf/music/Albums/Therion/2004a%20-%20Sirius%20B/folder.jpg

Does this happen every time?
Yes

Other information:
Comment 1 Jonathan Matthew 2008-03-18 10:05:31 UTC 
Fixed in svn.  Thanks for picking this up.

2008-03-18  Jonathan Matthew  <jonathan@d14n.org>

        * plugins/artdisplay/artdisplay/LocalCoverArtSearch.py:
        Return the full URI, rather than just the path.  Allows local cover
        art searches to work on SMB shares.  Fixes #517103.