After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 514415 - Columns list and its description should be Indented 12 pixels
Columns list and its description should be Indented 12 pixels
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: [obsolete] Visual Design
2.21.x
Other All
: Normal trivial
: 2.24.x
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-02-04 21:24 UTC by Marcin Gałązka
Modified: 2008-05-04 18:53 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
Proposed patch. (2.37 KB, patch)
2008-02-04 21:27 UTC, Marcin Gałązka 		committed Details | Review

Description Marcin Gałązka 2008-02-04 21:24:07 UTC 
Please describe the problem:
Other tabs in the preferences dialog use GtkAlignment with left_padding=12 to indent widgets. The 'Columns List' tab uses GtkHBox where first child is a dummy GtkLabel with '    ' (four spaces). It means that an indentation size is not constant and depends on the active font.

Steps to reproduce:
Open the preferences dialog (Edit->Preferences), switch few times between Display and Columns List to see a difference.


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Marcin Gałązka 2008-02-04 21:27:01 UTC 
Created attachment 104431 [details] [review]
Proposed patch.

This patch removes the dummy label and replaces GtkHBox with GtkAlignment.
Comment 2 Cosimo Cecchi 2008-02-25 22:15:05 UTC 
Good catch, confirming this.
Please subscribe to the nautilus mailing list [1] and submit there your patches for review, thanks.

[1] nautilus-list@gnome.org - you can subscribe from http://mail.gnome.org/mailman/listinfo/nautilus-list
Comment 3 Christian Neumair 2008-05-03 13:08:49 UTC 
Thanks, good catch! I committed a similar patch to trunk - yours did not apply cleanly anymore.
Comment 4 Cosimo Cecchi 2008-05-04 10:55:54 UTC 
I believe this can be closed as FIXED.

2008-05-03  Christian Neumair  <cneumair@gnome.org>

	* src/nautilus-file-management-properties.glade:
	Use 12 pixels of list column page indentation. Fixes #514415. Thanks
	to Marcin Galazka.
Comment 5 Marcin Gałązka 2008-05-04 18:53:50 UTC 
Yep, looks ok.