GNOME Bugzilla – Bug 513778
Migrate to gio
Last modified: 2008-02-02 19:20:19 UTC
Use gio instead of gnome-vfs.
Created attachment 104222 [details] [review] Add gio support. Drop gnome-vfs support.
Nice patch. Thanks. I'd prefer that VFS support were optional, so that you didn't need a bleeding-edge version of glib to compile & run the program. It can be as simple as a compile-time check: #if GLIB_CHECK_VERSION(2,15,4) #define HAVE_VFS_SUPPORT 1 #endif
Would it be possible to also have some public gio supporting functions, i.e. rsvg_handle_new_from_gfile and rsvg_handle_new_from_gfile_async ?
Sure, if someone has a concrete need for them.
Created attachment 104224 [details] [review] Make gio optional
Created attachment 104225 [details] [review] Fix missing config.h include
Created attachment 104228 [details] [review] Fix configure.in bug
Thanks!
Wheeh!! Thanks for the patch! There is a small issue with this (the pkg-config file): $ cat librsvg-2.0.pc prefix=/opt/jhbuild exec_prefix=${prefix} libdir=${exec_prefix}/lib64 includedir=${prefix}/include gnome_vfs_supported=@GNOME_VFS_SUPPORTED@ Name: librsvg Description: library that renders svg files Version: 2.21.0 Requires: glib-2.0 gdk-pixbuf-2.0 Requires.private: @LIBGNOME_VFS_PKG@ Libs: -L${libdir} -lrsvg-2 Cflags: -I${includedir}/librsvg-2 Note the @GNOME_VFS_SUPPORTED@ and @LIBGNOME_VFS_PKG@. Please fix the librsvg-2.0.pc.in file as well (I have no idea how).
Fixed.