After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 513627 - Use C_() instead of Q_() with context
Use C_() instead of Q_() with context
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
2.21.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
: 558336 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-02-01 06:53 UTC by Philip Withnall
Modified: 2008-10-29 14:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use Q_() instead of C_() with context (1.31 KB, patch)
2008-02-01 06:53 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2008-02-01 06:53:01 UTC 
As per http://live.gnome.org/GnomeGoals/MsgctxtMigration, we should use C_() instead of Q_() for messages with context.

Patch on its way.
Comment 1 Philip Withnall 2008-02-01 06:53:56 UTC 
Created attachment 104168 [details] [review]
Use Q_() instead of C_() with context
Comment 2 Bastien Nocera 2008-02-03 01:19:01 UTC 
We need to be able to require a newer glib that will have support for that, and be sure that the gettext version matches as well.
Comment 3 Philip Withnall 2008-05-25 22:08:10 UTC 
I believe all the major distributions now use intltool >= 0.36.3 and gettext >= 0.15. The first release of GLib with the C_ macro is 2.15.1, which we're already effectively requiring due to our use of GIO.

If we apply this patch, there are also apparently two instances which need to be changed in totem-pl-parser too.
Comment 4 Philip Withnall 2008-10-29 11:32:49 UTC 
*** Bug 558336 has been marked as a duplicate of this bug. ***
Comment 5 Philip Withnall 2008-10-29 12:04:25 UTC 
Committed to trunk and gnome-2-24.

2008-10-29  Philip Withnall  <philip@tecnocode.co.uk>

	* src/backend/video-utils.c (totem_time_to_string): Use C_() instead
	of Q_() to separate translation context from strings.
	(Closes: #513627)
Comment 6 Matthias Clasen 2008-10-29 14:24:19 UTC 
It is a string change, so you might want to reconsider that 2.24 commit.
Sorry for not making that more obvious.
Comment 7 Philip Withnall 2008-10-29 14:57:26 UTC 
2008-10-29  Philip Withnall  <philip@tecnocode.co.uk>

	* src/backend/video-utils.c (totem_time_to_string): Revert previous
	commit, which broke string freeze.