Bug 512589 – Port publish plugin to gio

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 512589 - Port publish plugin to gio


Summary:	Port publish plugin to gio


Status:	RESOLVED FIXED

Product:	totem
Classification:	Core
Component:	Plugins
Version:	unspecified
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	General Totem maintainer(s)
QA Contact:	General Totem maintainer(s)

URL:
Whiteboard:

Depends on:
Blocks:	512602

Reported:	2008-01-28 15:44 UTC by Bastien Nocera
Modified:	2008-03-25 15:25 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Port Publish plugin to GIO (1.77 KB, patch) 2008-03-16 14:27 UTC, Philip Withnall	committed	Details \| Review
Properly unref the input stream. (600 bytes, patch) 2008-03-24 11:39 UTC, Mathias Hasselmann (IRC: tbf)	committed	Details \| Review

Description Bastien Nocera 2008-01-28 15:44:10 UTC

./publish/totem-publish.c:      if (GNOME_VFS_OK != gnome_vfs_read (handle, buffer, size, &size)) {
./publish/totem-publish.c:              gnome_vfs_close (handle);
./publish/totem-publish.c:      if (GNOME_VFS_OK == gnome_vfs_open (&handle, url, GNOME_VFS_OPEN_READ))

Comment 1 Philip Withnall 2008-03-16 14:27:29 UTC

Created attachment 107387 [details] [review]
Port Publish plugin to GIO

Comment 2 Bastien Nocera 2008-03-16 14:29:36 UTC

Please don't reassign bugs to yourself, makes them disappear from the automatic mails. Patch looks alright, although the ABS() usage looks very weird to me.

Comment 3 Philip Withnall 2008-03-16 14:51:07 UTC

2008-03-16  Philip Withnall  <pwithnall@svn.gnome.org>

	* src/plugins/publish/totem-publish.c:
	(totem_publish_plugin_stream_cb), (totem_publish_plugin_media_cb):
	Convert the Publish plugin to GIO. (Closes: #512589)

Comment 4 Mathias Hasselmann (IRC: tbf) 2008-03-24 11:38:50 UTC

Thanks alot for the patch, but for me it seems that you unref the GInputStream too early in totem_publish_plugin_media_cb(). Suggesting the attached patch.

Comment 5 Mathias Hasselmann (IRC: tbf) 2008-03-24 11:39:23 UTC

Created attachment 107910 [details] [review]
Properly unref the input stream.

Comment 6 Philip Withnall 2008-03-25 15:25:51 UTC

2008-03-25  Philip Withnall  <pwithnall@svn.gnome.org>

	* src/plugins/publish/totem-publish.c:
	(totem_publish_plugin_media_cb): Patch from  Mathias Hasselmann
	<mathias.hasselmann@gmx.de> to properly unref the input stream in
	the publish plugin. (Closes: #512589)