After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 512456 - Prioritizing cover art from filesystem before covers folder
Prioritizing cover art from filesystem before covers folder
Status: RESOLVED WONTFIX
Product: banshee
Classification: Other
Component: Importing
git master
Other Linux
: Normal normal
: 2.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on: 528137
Blocks:
 
 
Reported: 2008-01-27 22:02 UTC by Asaf
Modified: 2009-06-05 22:43 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Asaf 2008-01-27 22:02:43 UTC
If music is added that in the folder there is no cover art than the plugin looks for the cover art. That's good. But sometimes the cover art is in low resolution. So when the cover art is scanned and entered as cover.jpg to the folder Banshee does not change the art until it is deleted from the .config directory (which by the way took a long time to understand that the files are there...).
The plug in should take the downloaded cover art if it does not find cover art in the directory, I think this should be checked with each presentation of the cover art. Thanks.
Comment 1 Andrew Conkling 2008-01-28 02:51:16 UTC
Just to make sure I understand this bug, you're saying that you're overriding Banshee's downloaded cover art with a file you set yourself? But that Banshee is not using it because it cached a copy of the downloaded art?
Comment 2 Asaf 2008-01-28 04:43:05 UTC
Yes. This is the situation: I enter a new album, the cover art plugin downloads the art work. Sometimes it is in low resolution or not the right one. I find the right one on google or something like that. Save it as cover.jpg in the folder. Banshee still displays the downloaded cover art. In order for it not to, I need to delete the file in the .config>bashee>covers folder then it displays the saved cover art.
BTW, there should be some GUI method to reach the folder that holds the downloaded cover art from banshee or at least some documentation about where it is. It took me a really long time to find out where it was so I could delete the downloaded cover art.

Thanks!
Comment 3 Andrew Conkling 2008-02-02 16:41:12 UTC
(In reply to comment #2)
> BTW, there should be some GUI method to reach the folder that holds the
> downloaded cover art from banshee or at least some documentation about where it
> is. It took me a really long time to find out where it was so I could delete
> the downloaded cover art.

Not that I'm a developer, but I don't agree that there needs to be any GUI method to get to the cached covers. What should be done is to correct this problem so that the correct art is always used. (The only reason for the cached copies is to make it faster to load them again after they've been imported.)
Comment 4 Asaf 2008-02-03 21:20:26 UTC
The problem is not that the incorrect art is used, but a lot of times a low resolution art work is used so finding another one is needed.
I noticed another thing that the cover art is incorrect in the ipod once the cover art is from the folder, what I suggest is something you mentioned but does not happen in banshee: "The only reason for the cached
copies is to make it faster to load them again after they've been imported." there is no cahcing of the cover art the is in the folder. Maybe a way to override many of the problems is by making a copy of the "cover.jpg" file in the cover art section (.config>banshee>covers) that way there is one central place that takes care of all the cover art.
Just a thought

Thanks for the reply
Comment 5 Pepijn van de Geer 2008-02-04 00:06:54 UTC
I think you can just drag and drop the new cover on the coverart in banshee to change it.
Comment 6 Andrew Conkling 2008-02-04 02:18:42 UTC
It certainly seems like one workflow would be to save the image into the folder, with the other option being to drag and drop it into Banshee. IMO Banshee should be smart enough to recognize new "overriding" images dropped into the folder, and give those precedence.

I don't know how much that would hit performance if that were checked every time. But perhaps this could be implemented.
Comment 7 Asaf 2008-02-06 17:05:40 UTC
I didn't know about the drag and drop option which essentially copies the cover art from the folder to the central cover art folder. This is a good solution but not that intuitive. I have not checked, but when doing this do it apply to all the songs on the album or just to the one that is marked at the time you drag and drop.
Another suggestion can be to add a tag in the "edit metadata" option that will show the cover art, then you can select a different one from your library. Or even better that it will show the options: for example the downloaded cover art, the cover.jpg, or if there are a few files in the folder then show all the options. Then with a simple click the cover art can be selected. Once selected a link is created to the correct file and put into the .config>banshee>covers folder so that this is will be the cover art presented and it is all managed in one place. I think this will also solve bug 512460 and bug 512457.

I do not know how to implement such a thing since I am new to Linux, but this can be a way to solve these problems
Just a thought.
Comment 8 Pepijn van de Geer 2008-02-06 19:06:08 UTC
Dropping the album sets the cover for the entire album. As it is right now I think banshee can only have coverart for the entire album, not on a per-song basis.

It might be worth rethinking the whole coverart thing for banshee-ng. 
Last year I tried to make the (disabled) cover art tab in the meta data window work, but ended up having difficulties with the way banshee handled the coverart.
It can come from different locations: embedded, folder, central cache. There was no way of really knowing which one was used if i remember correctly.
Maybe there should also be some provision of setting the cover art on a per song basis instead of on per-album basis although the latter makes more sense on most occasions.

I hope this all makes sense. It's been a while since i was working on this.
Comment 9 Richard Venneman 2008-04-30 10:00:30 UTC
I'm not sure if I'm at the right bug:

Banshee always downloads covers from the internet and never looks for cover.jpg's in my music directory.

My folder structure is like this:

~/Muziek/Artist/Artist-Album/
Comment 10 Alexander van Loon 2008-07-13 11:16:42 UTC
Even though this bug and bug #512457 are still reproducible on Banshee 1.0, the versions for these bugs are respectively marked as legacy branch and 0.13.2, could the versions please be updated?

And why are these two bugs not targeted to be fixed for 1.2? Is is deliberate, because these bugs are deemed not to be important enough? I really hope the Banshee developers will change their mind, because all the albums I have downloaded from Jamendo don't display any cover art because Banshee insists on finding cover art on the Internet, where it can't find any from relatively unknown artists publishing on Jamendo.
Comment 11 Andrew Conkling 2008-07-13 17:24:27 UTC
(In reply to comment #10)
> Even though this bug and bug #512457 are still reproducible on Banshee 1.0, the
> versions for these bugs are respectively marked as legacy branch and 0.13.2,
> could the versions please be updated?

The "Legacy branch" was a batch edit by Aaron a while ago, since 1.0 is such a departure from the old versions. Thanks for noticing that.
Comment 12 Wouter Bolsterlee (uws) 2008-11-10 08:53:24 UTC
(In reply to comment #5)
> I think you can just drag and drop the new cover on the coverart in banshee to
> change it.

Is this supposed to work currently? I can't figure out how it works... I'd suggest:

- allow dropping images on the track editor
- allow dropping images on the cover art image in the main window

Both should set the cover for the complete album.

(Note that Muine works in a similar way.)
Comment 13 Mariano Simone 2008-12-08 18:31:11 UTC
I'm running v1.4.1 and i have the same problem as http://bugzilla.gnome.org/show_bug.cgi?id=512456#c9

Banshee is downloading every cover art and don't looking into each album's directory
Comment 14 Gabriel Burt 2009-06-05 22:43:20 UTC
Closing this as WONTFIX.  A major part of the point of our cover art cache directory is to be able to avoid looking for cover art in all the places we look on every lookup.  Manually editing the cover art (via some UI in Banshee) is bug #336350