GNOME Bugzilla – Bug 511337
crash in Evolution: Simultaneously pressing ...
Last modified: 2008-07-16 04:57:00 UTC
What were you doing when the application crashed? Simultaneously pressing the "show" preview/arrow button on several very large image attachments in an e-mail. Distribution: Debian lenny/sid Gnome Release: 2.20.3 2008-01-12 (Debian) BugBuddy Version: 2.20.1 System: Linux 2.6.24-rc8 #2 Sat Jan 19 00:09:34 ARST 2008 i686 X Vendor: The X.Org Foundation X Vendor Release: 10400090 Selinux: No Accessibility: Disabled GTK+ Theme: Clearlooks Icon Theme: gnome Memory status: size: 228753408 vsize: 228753408 resident: 115007488 share: 25296896 rss: 115007488 rss_rlim: 4294967295 CPU usage: start_time: 1200849207 rtime: 44928 utime: 39756 stime: 5172 cutime:35 cstime: 20 timeout: 0 it_real_value: 0 frequency: 100 Backtrace was generated from '/usr/bin/evolution' Using host libthread_db library "/lib/i686/cmov/libthread_db.so.1". [Thread debugging using libthread_db enabled] [New Thread 0xb67e56b0 (LWP 5297)] [New Thread 0xb063db90 (LWP 32349)] [New Thread 0xb10feb90 (LWP 32347)] [New Thread 0xb3d25b90 (LWP 5607)] [New Thread 0xb2c8eb90 (LWP 5591)] [New Thread 0xb4526b90 (LWP 5584)] [New Thread 0xb3505b90 (LWP 5564)] [New Thread 0xb4d27b90 (LWP 5558)] [New Thread 0xb5528b90 (LWP 5557)] [New Thread 0xb5d29b90 (LWP 5556)] 0xb7fc3410 in __kernel_vsyscall ()
+ Trace 186378
Thread 1 (Thread 0xb67e56b0 (LWP 5297))
----------- .xsession-errors (44 sec old) --------------------- get jkohen pop://jkohen;auth=LOGIN@buddystream.com Find Items 0 get jkohen pop://jkohen@pop.fibertel.com.ar/ Find Items 0 get jkohen pop://jkohen;auth=LOGIN@buddystream.com Find Items 0 get jkohen pop://jkohen@pop.fibertel.com.ar/ Find Items 0 get jkohen pop://jkohen;auth=LOGIN@buddystream.com Find Items 0 get jkohen pop://jkohen@pop.fibertel.com.ar/ Find Items 0 get jkohen pop://jkohen;auth=LOGIN@buddystream.com Find Items 0 JACK tmpdir identified as [/dev/shm] --------------------------------------------------
To make myself more clear, by "simultaneously" I mean that first I pressed said button for the bottom image, then before it was shown, I pressed the button for the one before it, then before any of the two previous were shown, I pressed the button for the third and so on, until it crashed. In total there were 6 image attachments and I think I made it through four before Evo crashed.
*** Bug 528460 has been marked as a duplicate of this bug. ***
see bug 509772
Hmm, seems like a good regression, after click on the image it doesn't clear the output and doesn't show "formatting message", so we are back where we were. (bug #273386 as Akhil pointed out on IRC) I've such a feeling I reverted/improved that change because it didn't remember scroll bar position, which was somehow irritating. Let me check whether I'll be able to improve it in a correct way, not in that workaround last time... Note: I am able to reproduce it... [very sadly] (Btw, if someone else will do that before me, then I'm fine with that) :)
Created attachment 109479 [details] [review] proposed evo patch for evolution; Not the proper patch yet, it's another workaround, but should prevent the issue very well. It either clears the content of the preview or disables it during formatting message, so users cannot click on attachment buttons until the new formatting is done.
Milan, how about just desensitizing that button alone? the whole widget might not look good.
To be honest, the whole widget doesn't change much, when I disable it. The other thing is it's "very hard" to find all embedded widgets (you know, we should disable all buttons, not only the one user touched). I noticed only one pity thing, for my test mail, it grayed widgets (not disabled, but removed them and let there a gray rectangle) a few seconds before finishing formatting. That can be a problem you are talking about, I agree. Anyway, the best fix would be to rewrite whole part, but that's something really "impossible" :)
Milan, really speaking, I dont want to fix it then. I would say that it is a negative case, keep pressing to make it crash.
Srag, but see that bug #273386, there are many people doing this.
Created attachment 110031 [details] [review] proposed evo patch ][ for evolution; Done as srag suggested on IRC.
Milan, looks awesome. Commit to stable/trunk. I haven't tested it. Just test and commit.
Committed to trunk. Committed revision 35437. Committed to gnome-2-22. Committed revision 35438.
*** Bug 509772 has been marked as a duplicate of this bug. ***
*** Bug 537879 has been marked as a duplicate of this bug. ***
*** Bug 538083 has been marked as a duplicate of this bug. ***
*** Bug 543079 has been marked as a duplicate of this bug. ***