Created attachment 102946 [details] [review]
revision 1

This seems to be a combination of changes in Firefox and changes resulting from the performance enhancements.  If you use earlier (pre-performance changes) versions of Orca with the current Firefox, the problem is evident.  If you use earlier versions of Firefox with the current Orca, the problem is *not* evident.  So I think they changed something and we changed something and the two changes combined are problematic. <shrugs>

This patch causes our new method for obtaining the contents of the line to be sure to base our extents on the combo box rather than the text in the menu item.

I did some initial brief testing and it seems to solve the problem.  I am going to update our regression tests and test this further.  In the meantime, Mike please test.  Thanks!

this seems good.

Created attachment 102956 [details] [review]
revision 2

Actually, that was a hack. Make that a kludge. ;-)

I took a closer look.  When we get the extents of a menu item in a combo box, the extents we get are the same as the combo box.  The problem is that the menu itself exposes its full size even when it is collapsed.  I don't think it should.  Perhaps this is what changed in FF -- and didn't matter before the performance enhancements because we weren't looking at ancestor's extents trying to figure out where the blessed line begins. <smile>  Anyhoo, this patch looks to see if we're in a menu whose parent is a combo box and if so, gets the extents of the combo box.

Mike, please test this version. Thanks!

This looks like a relatively safe patch, and if it works, hey, that's great.  :-)  Thanks!

Works for me.  thanks 

Pylinted, regression tested, committed.  Moving to pending.

As decided in team meeting, closing as FIXED.