Created attachment 102902 [details] [review]
Move Zoom and View As

Here's Stephen Cook's patch from bug #80363.

err... but that is a patch for 2.15.91?! we are 2.21 now.

It was current when it was submitted, but it was never reviewed. I'm not up to snuff, but what's the best way to get the patch updated/reviewed?

update it to current svn codebase and ask for review on nautilus-list@

I've updated it to current svn

Had two remove three unused functions (they would cause compile warnings->errors)

from a first test run, zooming works but switching to/from icon view does not work.

Created attachment 104325 [details] [review]
Move Zoom and View controls to main toolbar

zooming works but switching to/from icon view does not work.

we should also right-align the view as and the zoom control

I don't think the zoom and view widgets should be placed in
nautilus_navigation_window_activate_throbber()

Any chance to get a fully working patch (I mean the combobox)?

Thanks for the bug report and your patch. A similar report (with patch attached) has been filed, and that is already marked as blocked by the toolbar customization one, which seems the way to go for this. I'm marking this bug as a duplicate of the other, feel free to report any other bug you find.

*** This bug has been marked as a duplicate of 525721 ***

As per comment #9 on bug 525721 (http://bugzilla.gnome.org/show_bug.cgi?id=525721#c9), this doesn't seem to be a duplicate, though it is certainly similar. Since there wasn't a reply there, I'm reopening this.

This bug suggests changing the default behavior to use the toolbar space more efficiently and is separate from the ability to customize the toolbars.

Hello,

Just posting this to say I'm interested in how this bug evolves, because I think the location toolbar is currently crowded and moving those controls that have nothing to do with location would help. :)

As to why I think the location toolbar is overcrowded, see this:
http://files.covertprestige.info/permanent/bugreport/nautilus-lost-space.png
The "zoom" and "view as" options may be useful, but if your Nautilus window is not at least 800px wide it just feels cramped (I can barely see three directories in the text field). It's notworthy that the recent addition of a text label on the left helped create this situation. I guess in English the label is "Place" (5 letters), but the only French translation, "Emplacement" (11 letters) is much bigger.

I know the whole Gnome project fights against optionitis, but on the user side a simple option to display those controls 1) in the main toolbar, 2) in the location bar and 3) not at all... well, that would be great. :)
You may even hide the option as something that's only available through gconf, so as not to confuse some/most users.

Created attachment 138633 [details]
Screenshot showing the different states of the toolbar

I've been working on a series of patches that changes the toolbar to make it more streamlined and simpler to use by unifying the two main toolbars and removing little used or redundant controls. This makes much better use of the screen - saves us about 20-50px vertical, depending if we remove the labels or not. This is really good for netbooks with small screen but also lets laptop/desktop users see more of their documents instead of a toolbar!

For the moment it's mostly proof of concept but if we can agree on how to move on I'll make it complete.

About the patch
 - All separators have been removed
 - Stop and Relad has been combined to a single button
 - Computer, Zooming, View mode has been removed
 - Location bar has been put to the main toolbar
 - Location button has been removed
 - View -> Location in the menu has been removed

Future suggestion
 - Adding a zooming widget to the status bar (like the one in openoffice [1])

Attached is also a screenshot showing the different states of the toolbar.

Is this something we would like to do with nautilus?
Comments? 

[1] http://static.blogo.it/ossblog/openoffice-30-beta-1/big_03writer.png

Created attachment 138634 [details] [review]
Patch to unify the main and location toolbar

Why remove the separators and the location button?

removing separators is o.k. in my eyes, as the toolbar-editor (which is requested for years) should take care about that. but -1 for the missing location button.

About the location button - I don't think it's clear what it does (at least my icon [looks like a paper to be edited]) and it takes up space for something I think few people use. The people who know how to get to a folder by typing surly has used the ctrl + L command in Firefox and this is the same...

Me personally has never used it (actually tried it now and it seemed broken).

Or I'm I wrong? Or could we add this feature by for example double click the current folder in the breadcrumb?


About the separators - what to separate? There are so few buttons left and almost all belong to separate groups. So it would be almost a separator between every button;
[B] [F] [R/S] | [H] | [S] | [Location]
Three separators on 5/6 buttons seems a little bit overkill (?)

(In reply to comment #17)
> About the location button - I don't think it's clear what it does (at least my
> icon [looks like a paper to be edited]) and it takes up space for something I
> think few people use. The people who know how to get to a folder by typing
> surly has used the ctrl + L command in Firefox and this is the same...
> 
> Me personally has never used it (actually tried it now and it seemed broken).

You're wrong. I use it virtually every day, as do many, many users. It works exactly as designed.
 
And I don't think it's appropriate to merge the patch. We really want to go the toolbar editor path rather than arbitrarily rearranging the buttons between releases. On top of that, we already have a load of sensible requests for other buttons but adding them would currently waste more space for lots of users, and it wouldn't be feasible with a layout like this. In the future it might even make sense to let extensions add buttons, like nautilus-svn/-bzr/-whatnot.

A. Walton, so even with re-adding the location button this wont be merged?

Then let's this toolbar editor happen! I would definitely like to help out with this one, even if seems a little bit to big for me to handle. But if someone could help with mentoring and making mockups I could give it a try.

this would be the best :)

Well I'm not a big C-Developer, but I will try to help you when the base-prose is done.

Well I'm not the only Nautilus maintainer nor the most important, there's always Alex and Cosimo which are usually around more than me, but I definitely wouldn't merge it. It just removes features for a bit of horizontal space and severely restricts the future direction of the toolbar since adding or changing almost anything would just disrupt the layout. It doesn't even save all that much space at all on my layout, though I have to admit mine's probably not the standard to go by (turned off button labels, use 16x16 icons, etc).

The toolbar editor patch in the other bug should be pretty far along, but it needs to be updated. I think it predates the GIO merge, but luckily life hasn't changed too much on the UI side of Nautilus that it can't be salvaged. Christian simply doesn't have the time necessary to bring it up to date, but the code's all there in the bug linked above.

@awalton: I completely agree with you that the toolbar editor is the way forward, rather than fighting to try to come up with a solution for all the toolbar-button-related bugs filed in bugzilla.

@Marcus: if you want to work on that, as awalton said, you can try to iterate from Christian's patch in bug #42834. Feel free to join #nautilus on IRC and ping some of us if you need any help or advice.

As the toolbar editor is getting closer and we certainly don't want to do the things in this patch; can't we close it as a WONTFIX?

Marking this bug as a duplicate of the other toolbar bug makes more sense to me. In that case the other toolbar bug needs a proper comment that summarizes this report — otherwise the information in this report might go lost or unnoticed.

Zoom and view controls have been moved to the main toolbar. Closing as obsolete.

(In reply to comment #25)
> Zoom and view controls have been moved to the main toolbar. Closing as
> obsolete.

Sounds FIXED to me. ;)

Thanks all!