After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 506659 - [textoverlay] rendering error when using non-standard widths
[textoverlay] rendering error when using non-standard widths
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal minor
: 0.10.20
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 485729 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-01-01 10:13 UTC by Sean D'Epagnier
Modified: 2008-06-02 18:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
this patch is only a quick workaround (402 bytes, patch)
2008-01-01 10:14 UTC, Sean D'Epagnier 		none Details | Review

Description Sean D'Epagnier 2008-01-01 10:13:25 UTC 
The gst_text_overlay_blit_yuv420 function incorrectly draws.

To reproduce:

gst-launch videotestsrc ! videoscale ! video/x-raw-yuv,width=796 ! clockoverlay ! ffmpegcolorspace ! autovideosink

with a width of 800, the problem goes away


Also commenting out line 956 in gsttextoverlay.c makes the problem go away for all widths, I am not sure what this line is supposed to do.
Comment 1 Sean D'Epagnier 2008-01-01 10:14:53 UTC 
Created attachment 101934 [details] [review]
this patch is only a quick workaround
Comment 2 Tim-Philipp Müller 2008-06-02 18:39:19 UTC 
This seems to fix it for me:

 2008-06-02  Tim-Philipp Müller  <tim.muller at collabora co uk>

        * ext/pango/Makefile.am:
        * ext/pango/gsttextoverlay.c: (gst_text_overlay_shade_y),
          (gst_text_overlay_blit_yuv420), (gst_text_overlay_push_frame):
          Use gstvideo functions to calculate strides and plane offsets. Fixes
          rendering issue ('ghost' images of the text on the chroma planes)
          with widths or heights that are not multiples of 8 (#506659 and
          probably also #485729).

        * tests/icles/test-textoverlay.c: (show_text), (test_textoverlay),
          (main):
          Test with odd height/width too.


Please re-open if you still have issues with that fix applied.
Comment 3 Tim-Philipp Müller 2008-06-02 18:40:58 UTC 
*** Bug 485729 has been marked as a duplicate of this bug. ***