After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 506506 - --disable-gtk-doc does not work
--disable-gtk-doc does not work
Status: RESOLVED FIXED
Product: libgoffice
Classification: Other
Component: General
0.6.x
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
: 505068 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-12-31 00:07 UTC by Robin Cook
Modified: 2008-03-20 19:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (3.23 KB, patch)
2008-01-04 18:51 UTC, J.H.M. Dassen (Ray) 		none Details | Review

Description Robin Cook 2007-12-31 00:07:26 UTC 
goffice 0.6.1 fails to compile without gtk-doc even when --disable-gtk-doc is set.
Comment 1 samverstraete 2008-01-04 09:37:19 UTC 
i can confirm this ...

gtk-doc has to be installed inf version 1.9 for goffice to install... even when you pass --disable-gtk-doc
Comment 2 J.H.M. Dassen (Ray) 2008-01-04 18:51:16 UTC 
Created attachment 102145 [details] [review]
Patch

It's not the compile that fails, but "make install" which does. The problem
is a shell script fragment in gtk-doc.make (and through it,
docs/reference/Makefile.in) whose logic is slightly broken. It assumes that
	cmd1 && cmd2
is identical to
	if cmd1; then cmd2; fi
but the error handling for them is different: if cmd1 fails, $? will be set
to non-zero after "cmd1 && cmd2" whereas it will be zero after "if cmd1;
then cmd2; fi".

The issue is fixed when things are regenerated with a newer version of
gtk-doc-tools.

For the 0.6.1 release, this patch fixes this issue. (Aside from systems like
Solaris which are affected by the related bug #502410)
Comment 3 Morten Welinder 2008-01-04 23:58:54 UTC 
*** Bug 505068 has been marked as a duplicate of this bug. ***
Comment 4 J.H.M. Dassen (Ray) 2008-01-05 18:10:51 UTC 
I haven't managed to find out where the gtk-doc.make with broken error
handling came from exactly, but 
	http://svn.gnome.org/viewvc/goffice?view=revision&revision=2027
will hopefully prevent the broken version from being used when producing new
release tarballs.
Comment 5 Morten Welinder 2008-01-05 18:58:58 UTC 
That's too crude.  It will prevent me from building, for example.
Comment 6 J.H.M. Dassen (Ray) 2008-01-06 10:03:42 UTC 
It can probably be loosened (or perhaps even dropped) if we knew more about
the problematic gtk-doc-tools version that was used in creating the 0.6.1
tarball. Jody, can you enlighten us on this?
Comment 7 Morten Welinder 2008-01-07 14:22:49 UTC 
JHM: Can't we just look at the generated Makefile and see if it is right?
Comment 8 J.H.M. Dassen (Ray) 2008-01-07 18:38:16 UTC 
I'd be happier if the build system itself would take care of things, but
sure, it can be checked manually.
Comment 9 Morten Welinder 2008-01-25 02:02:16 UTC 
JHM: Please test svn trunk.

2008-01-24  Morten Welinder  <terra@gnome.org>

	* autogen.sh: Replace last change with a final test for the actual
	bug in question.
Comment 10 J.H.M. Dassen (Ray) 2008-01-26 13:16:26 UTC 
trunk's autogen.sh works fine for me with gtk-doc 1.9 and breaks off
properly when I fake having the broken gtk-doc installed, so I'm happy with
this approach.
Comment 11 Morten Welinder 2008-01-26 13:55:38 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.