After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 505949 - String fixes for EOG HEAD
String fixes for EOG HEAD
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
2.21.x
Other All
: Normal trivial
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-12-27 19:11 UTC by Seán de Búrca
Modified: 2007-12-28 12:37 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22



Description Seán de Búrca 2007-12-27 19:11:52 UTC
Please describe the problem:
At line 1181 of src/eog-window.c, the string "Saving image \"%s\" %s" is non-obvious for translation. Ideally, this should probably read "Saving image \"%s\" (%d/%d)". Displaying (1/1) doesn't seem like a big deal and solves the problem of potentially weird spacing if that portion of the string would be moved elsewhere in the translation. Additionally, a translator's comment should probably be added.

At line 891 of data/eog-image-properties.glade, "<b>Location:</b>\t" should have the tab removed. Surrounding whitespace should not be included in translatable strings.

At line 1424 of data/eog-image-properties.glade, "Metadata" should be translatable.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Felix Riemann 2007-12-28 12:37:02 UTC
(In reply to comment #0)
> At line 1181 of src/eog-window.c, the string "Saving image \"%s\" %s" is
> non-obvious for translation. Ideally, this should probably read "Saving image
> \"%s\" (%d/%d)". Displaying (1/1) doesn't seem like a big deal and solves the
> problem of potentially weird spacing if that portion of the string would be
> moved elsewhere in the translation. Additionally, a translator's comment should
> probably be added.
> ...
> At line 1424 of data/eog-image-properties.glade, "Metadata" should be
> translatable.
> 

Agreed. :)

> At line 891 of data/eog-image-properties.glade, "<b>Location:</b>\t" should
> have the tab removed. Surrounding whitespace should not be included in
> translatable strings.

Yes, this was apparently an oversight. As removing the tab will reuse an existing translation I'm going to change this in the gnome-2-20 branch as well.

I applied your proposals (Thanks!) to trunk, added a translator comment and fixed some other related datatype/string issues while at it. Announcement mail coming in a few minutes.

2007-12-28  Felix Riemann  <>

	Fix several translation and other string issues.
	Fixes bug #505949 (Seán de Búrca, Felix Riemann).

	* src/eog-jobs.h: Change the index-variable's datatype to guint to
	coincide with the one returned by g_list_length.
	* data/eog-image-properties-dialog.glade: Add a new translatable
	string and correct another one.
	* src/eog-window.c: (eog_job_save_progress_cb): Make the statusbar
	message while saving images more translator-friendly. Add a translator
	comment. Use the correct format tokens in the printf-statement.


-------------------------------------------------------------------------------
This problem has been fixed in our software repository.
The fix will go into the next software release. Thank you for your bug report.