GNOME Bugzilla – Bug 505306
Orca's color filtering combo box should be greyed out if the filters are not available
Last modified: 2008-07-22 19:33:06 UTC
Our new Advanced Settings dialog has a combo box in which a user can specify a color filter from libcolorblind. Currently we have no way of knowing whether a user has libcolorblind installed or not, therefore the control is always available, but doesn't always work. We should grey it out if the color filters are not available. We need this information from gnome-mag (see bug 502893).
Created attachment 101522 [details] [review] revision 1 Carlos has attached a patch to the gnome-mag bug we're depending on. (See http://bugzilla.gnome.org/attachment.cgi?id=101399&action=view) This patch has been tested with gnome-mag with and without Carlos' patch and with and without libcolorblind installed. It seems to be doing the right thing. Please test. (Rich, please look over the changes I made to the setup dialog. Thanks!)
> Please test. This seems to work just fine. > (Rich, please look over the changes I made to the setup dialog. Thanks!) Changes look good. Thanks for using glade-2 !
Thanks Rich. > Changes look good. Thanks for using glade-2 ! ;-) Patch committed. Moving to pending.
I tested this patch with gnome-mag with and without Carlos' patch and with and without libcolorblind installed and the combo always comes up greyed. I think my colorblind build is bad, though, since I cannot run the colorblind applet. If this works as expected for you, I think it's OK to close this bug as FIXED.
I've never been able to run the colorblind applet either. The order of everything matters though. You have to first build libcolorblind. Then you have to (re)autogen.sh gnome-mag (as that's when it looks for libcolorblind) and rebuild it. I'll give it a try in Solaris. In terms of Hardy, it did work as expected until gnome-mag stopped building in Hardy. <shrugs>
(In reply to comment #5) > I've never been able to run the colorblind applet either. Ha! I was able to add it to the panel and then it magically appeared when I rebooted my machine. It takes over Shift+Ctrl+c to enable filtering and Shift+Ctrl+n to switch between filters. I can run this just fine when Orca is running, and when I do so, the filters take effect in the magnifier. But, the combo still comes up greyed for me. In any case, the fact that the applet works makes me wonder if we really need this in the Orca preferences UI. What do you think?
As discussed in team meeting, we are going to keep it in the Orca preferences UI. Closing this bug as FIXED.