After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 504538 - When image is not found, eog shows broken background for the message
When image is not found, eog shows broken background for the message
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
2.21.x
Other All
: Normal minor
: ---
Assigned To: EOG Maintainers
EOG Maintainers
: 575125 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-12-19 20:31 UTC by Patryk Zawadzki
Modified: 2009-03-12 22:12 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
The error message with incorrect background (25.38 KB, image/png)
2007-12-19 20:32 UTC, Patryk Zawadzki
Details

Description Patryk Zawadzki 2007-12-19 20:31:56 UTC
Please describe the problem:
When you try to open a non-existing image, eog displays a message but the background is wrong (see attached screenshot).

Steps to reproduce:
Just open a file that does not exist (the way I hit this was using the recent documents menu).

Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Patryk Zawadzki 2007-12-19 20:32:46 UTC
Created attachment 101276 [details]
The error message with incorrect background
Comment 2 Felix Riemann 2007-12-23 18:32:02 UTC
Confirming.
This only happens when using the recent files menu. It works when trying to open a non-existing file from the command line.

When I then change the window size the message area will redraw correctly, btw.
Comment 3 Jones Lee 2008-05-24 09:28:01 UTC
I find the inline error dialog is not very sane since we have to deal all theming issues related to that dialog (please excuse me if I am wrong). IMHO, why don't we just have simple pop-up dialog like Mac Image Viewer and Windows Viewer? 
Comment 4 Claudio Saavedra 2008-09-04 19:38:08 UTC
Well, I see other redrawing issues as well (drag the rigth border of the window to the right and see the right border of the area being drawn incorrectly.
Comment 5 Claudio Saavedra 2008-09-04 21:30:13 UTC
well, we weren't handling the size allocation. I set up a size_allocation() callback for the "size-allocation" signal to call gtk_widget_queue_redraw(), so that we ensure that the widget is drawn correctly when the size of the window changes (or upon the initial allocation). Fixed in trunk.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.


2008-09-05  Claudio Saavedra  <csaavedra@igalia.com>

	* src/eog-message-area.c: (size_allocate), (eog_message_area_init):
	Enqueue a redraw of the widget upon allocation. Fixes bug #504538.
Comment 6 Matthias Clasen 2008-10-07 13:56:56 UTC
I noticed some redraw issues on resize, but I think I fixed them all.
But thanks for the notice.
Comment 7 Matthias Clasen 2008-10-07 14:05:06 UTC
One more thing to consider is if we really want to hardcode using the tooltip theming here, or make this widget independently themeable. There's some tricky issues with fallback, though.
Comment 8 Claudio Saavedra 2009-03-12 22:12:48 UTC
*** Bug 575125 has been marked as a duplicate of this bug. ***