GNOME Bugzilla – Bug 503413
enhance remote control interface: toggle mute
Last modified: 2008-12-05 15:13:22 UTC
There are commands totem --volume-up/down nut no the similar command to toggle mute. To make remote control interface a "complete" solution for remote controlling it would be useful to have the similar command for toggle mute functionality.
We don't handle "mute", we only handle 0-volume. I'd be happy to add get/set-volume command-line options though.
From "remote conroller" side of view it is more easy to operate by toggle_mute requests (inside totem it could be realized as 0-volume/previous-volume of cource). In this case there are no needs to store volume value somethere for "remote controller"
Created attachment 113604 [details] [review] Adds toggle mute to the remote control interface. This patch adds --mute remote control interface to toggle mute. As this is my first code patch for gnome I'm not terribly sure if this is a good/proper implementation.
I'd rather you added a totem_action_toggle_mute() function, and did all the work in there instead.
2008-12-05 Bastien Nocera <hadess@hadess.net> * src/totem-options.c (totem_options_process_for_server): * src/totem-options.h: * src/totem-private.h: * src/totem.c (totem_action_exit), (totem_action_volume_relative), (totem_action_volume_toggle_mute), (volume_button_value_changed_cb), (totem_action_remote): * src/totem.h: Add proper support for mute toggling through the remote interface, and add a command-line option for it (Closes: #554318)