GNOME Bugzilla – Bug 502826
Wording: options of reply style and forward style dont match
Last modified: 2008-04-10 09:24:55 UTC
In Evolutions preferences under "Composer Preferences" there are two settings "Forward Style" and "Reply style" that have 3 options in common. But those are different named: Forward style Reply Style Attachment <-> Attach original message Inline <-> Inline original message (Outlook style) Quoted <-> Quote original message I would propose to drop the "original message"-ones as this is obvious amd the shorter ones are much better readable. It would also be nice, if the 3 options would have the same order in the two drop down boxes.
Created attachment 101006 [details] [review] Rewords and reorders reply styles to match forward styles Definitely works with English, ought to work with other languages too because the reply styles are in the translations.
This patch makes me happy. :-)
Nick, I would prefer to go with long text. Atleast the last one is a long text. Let it be uniform. You also need to take care of migration. 2.12 users may have 0/1/2 in gconf and you change the order in the enum and it is gonna break for them. Either don't change the order (Bad to look at) or please do the migration code. (em-migrate.c)
Bumping version to a stable release.
Created attachment 107088 [details] [review] proposed evo patch (updated one) for evolution; Nick is not CC'ed on this too, hard to say whether he knows about the above comment. This patch is only updated one from that Nick's, it doesn't need any migrate code (which btw doesn't work well for svn/development version users anyway). I change a bit words there too, it doesn't look so bad from my point of view.
Milan you sure that it doesn't require migration for 2.22/2.12 users? I doubt it. I think in gconf we store 0/1/2 which earlier mapped to a different list and now a new list.
I workaround it, see attach_style_reply_new_order function.
Ah, ok. Gotcha. Commit it.
Committed to trunk. Committed revision 35262.
*** Bug 458506 has been marked as a duplicate of this bug. ***
Created attachment 108943 [details] [review] Wording: options of reply style and forward style Now both options are matching
I thought this is already fixed, in trunk only, but it is. We cannot push it to stable (2.22.x), because it's under freeze.