After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 501391 - crash on NULL string
crash on NULL string
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] Appearance
unspecified
Other opensolaris
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 492667 503605 503606 509735 518175 518719 518730 522475 531433 531995 553285 553286 553408 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-12-03 22:33 UTC by Brian Cameron
Modified: 2008-09-23 15:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch fixing problem (769 bytes, patch)
2007-12-03 22:33 UTC, Brian Cameron 		committed Details | Review

Description Brian Cameron 2007-12-03 22:33:02 UTC 
The attached patch fixes a crashing situation where the filename doesn't exist and is NULL.  On Solaris, when you try to print NULL strings, it causes crashes.  

Can this go upstream?
Comment 1 Brian Cameron 2007-12-03 22:33:21 UTC 
Created attachment 100149 [details] [review]
patch fixing problem
Comment 2 Jens Granseuer 2007-12-04 18:09:35 UTC 
Thanks.

2007-12-04  Jens Granseuer  <jensgr@gmx.net>

        Patch by: Brian Cameron <brian.cameron@sun.com>

        * gtkrc-utils.c: (gtkrc_get_details), (gtkrc_get_color_scheme):
        printing NULL strings crashes on Solaris so don't do that (bug #501391)
Comment 3 Jens Granseuer 2007-12-14 14:46:52 UTC 
*** Bug 503605 has been marked as a duplicate of this bug. ***
Comment 4 Jens Granseuer 2007-12-14 14:47:15 UTC 
*** Bug 503606 has been marked as a duplicate of this bug. ***
Comment 5 Jens Granseuer 2007-12-14 14:48:52 UTC 
*** Bug 492667 has been marked as a duplicate of this bug. ***
Comment 6 Brian Cameron 2008-01-04 21:58:01 UTC 
Looking at the latest release of gnome-control-center-2.21.4 (released on December 21st after the commit) and this fix isn't included.  Neither is the fix in SVN head.  It seems that this change got lost or was never applied.  

So, I'm reopening.  Can this patch really be applied?  :)
Comment 7 Thomas Wood 2008-01-13 18:11:25 UTC 
Brian, if you check revision 8330, you will see Jens changed the logic slightly so that the print code is never reached if the filename is NULL.


See: http://svn.gnome.org/viewvc/gnome-control-center/trunk/capplets/common/gtkrc-utils.c?r1=8309&r2=8330
Comment 8 Bruno Boaventura 2008-01-15 21:30:23 UTC 
*** Bug 509735 has been marked as a duplicate of this bug. ***
Comment 9 Gianluca Borello 2008-02-23 12:14:22 UTC 
*** Bug 518175 has been marked as a duplicate of this bug. ***
Comment 10 Jens Granseuer 2008-02-25 23:00:49 UTC 
*** Bug 518719 has been marked as a duplicate of this bug. ***
Comment 11 Jens Granseuer 2008-02-25 23:25:59 UTC 
*** Bug 518730 has been marked as a duplicate of this bug. ***
Comment 12 Jens Granseuer 2008-03-14 18:10:18 UTC 
*** Bug 522475 has been marked as a duplicate of this bug. ***
Comment 13 Gianluca Borello 2008-05-05 10:21:46 UTC 
*** Bug 531433 has been marked as a duplicate of this bug. ***
Comment 14 Jens Granseuer 2008-05-07 17:54:25 UTC 
*** Bug 531995 has been marked as a duplicate of this bug. ***
Comment 15 Jens Granseuer 2008-09-22 18:54:18 UTC 
*** Bug 553285 has been marked as a duplicate of this bug. ***
Comment 16 Jens Granseuer 2008-09-22 18:56:20 UTC 
*** Bug 553286 has been marked as a duplicate of this bug. ***
Comment 17 André Klapper 2008-09-23 15:54:24 UTC 
*** Bug 553408 has been marked as a duplicate of this bug. ***