GNOME Bugzilla – Bug 501140
IMAP provider missing mnemonics
Last modified: 2010-04-17 18:33:13 UTC
Please describe the problem: The Camel providers for Hula, IMAP, and IMAP4 are missing mnemonics for the "Command" and "minutes" widgets in the account preferences dialogs. Steps to reproduce: 1. Edit->Preferences 2. Create an account, using server type "Hula" or "Imap" 3. Proceed to the "Receiving Options" screen. The "Command" and "minutes" widgets are missing mnemonics. Actual results: Expected results: Does this happen every time? Other information: This bug is part of http://bugzilla.gnome.org/show_bug.cgi?id=329578
Created attachment 100080 [details] [review] Patch adds missing mnemonics This patch adds the missing mnemonics. In addition, it also creates a mnemonic for the "Namespace" label in IMAP/IMAP4 providers.
Created attachment 100082 [details] [review] Revised patch Sorry for the spam :) This patch is the same as the first, except with updated references to the new bug number in the ChangeLogs.
Hello Alex.. Nice work.. :) Thanks for the patch.. Also.. during account creation, using 'POP' provider, in the 'Receiving options' tab, under 'Message storage': mnemonics for the following are missing: i) Leave messages on server ii) Delete after n day(s) [Note: two mnemonics missing here] iii) Disable support for all POP3 extensions Could you provide a single patch with all the fixes (including the ones I've mentioned here) and a single ChangeLog entry ? TIA !!
schooms: needinfo? what for? you don't need info at all here.
Suman, if you review it and think it needs work, mark them as that. Anyways, nice initiative in starting reviewing small patches.
(In reply to comment #4) > schooms: needinfo? what for? you don't need info at all here. > hmm.. not the bug, but the patch.. anyhow.. ok :) (In reply to comment #5) > Suman, if you review it and think it needs work, mark them as that. > > Anyways, nice initiative in starting reviewing small patches. > no... just happened to notice the missing mnemonics... thought it could go in well with the existing patch.. :)
Suman: even the patch does not require additional information (and this is the definition of NEEDINFO in gnome bugzilla) from the reporter. i don't want to see bug reports rotting away as NEEDINFO without even asking a question to the submitter. thanks.
Created attachment 100584 [details] [review] Revised patch This patch is the same as my original, except that it only adds one ChangeLog entry. As for the POP3 provider, a fix for those mnemonics was committed to trunk in revision 8267 by Milan, about 4 days ago.
It's pity that different parsons have different opinions on same thing. I usually choose nearest ChangeLog to the file I change in a source tree, and because each provider has it's own ChangeLog entry, then it should be written in each of them, not in camel's ChangeLog. Hula account has "Namespace" too, but you forgot the mnemonic there. With respect to this mnemonic, the underscore under 'p' is not visible at all for me, please choose other letter, say 'E'? Thanks in advance.
yes, as Milan said, please use the ChangeLog closest to the file modified.
Hula is dead anyway. Dead.
Wow, times have changed. The hula and imap4 providers are gone, and we don't use ChangeLogs anymore. Anyway, committed the imap provider hunk. This shouldn't have taken three years. http://git.gnome.org/browse/evolution-data-server/commit/?id=a18266a9525f790a498937a6c567fbbd565a0581