GNOME Bugzilla – Bug 500819
Thumbnails should have a frame like in nautilus
Last modified: 2007-12-07 23:17:03 UTC
iirc the code is stolen code from eog, eog sidebar currently uses frames, I think it didn't some weeks ago, maybe you want to update? or if i'm wrong about the stealing, then you want to consider the frames :).
We don't use the eog sidebar. Just some drop shadow code was copied. Closing as invalid
Would you consider adding the frame anyway? (like nautilus' thumbnails)
any reason for this?
For consistency with the rest of the desktop and because it looks nice :). The bg is white and the shadow is black, the edges of the picture are not clear. It just looks better.
Good point. Reopening the bug
You should just grab eog-thumbnail.c from eog trunk. It's the same as thumb-shadow but updated and with easier and better eye candy. Above that, it's maintained.
Created attachment 100555 [details] [review] Updates eog-thumb-shadow to eog-thumbnail for better thumbnails and code An update!.
Created attachment 100558 [details] Forgotten file The needed .png.
Created attachment 100560 [details] How it looks. The important aesthetic thing to note is that there's a white border on the original image followed by a black border. This makes the image nicely framed :). I honestly think it looks better and it's a good idea to have up-to-date code (eog-thumb-shadow is dead nowadays in eog). But this is subjetive.
diego, please stop using dark themes, just because they were populated on the planet ;)
Woohaa, we convinced daniel 2007-12-08 Jaap Haitsma <jaap@haitsma.org> * configure.ac, data/Makefile.am, data/pixmaps, data/pixmaps/Makefile.am, data/pixmaps/thumbnail-frame.png, data/wscript_build, src/cheese-thumb-view.c, src/eog-thumbnail.c, src/eog-thumbnail.h, src/eog-thumb-shadow.c, src/eog-thumb-shadow.h, src/Makefile.am: Give thumbnails frame like in nautilus and eog Fixes bug #500819 Patch by Diego Escalante Urrelo <diegoe@gnome.org>