After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 499723 - Find dialog jumps to hidden sheets
Find dialog jumps to hidden sheets
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: GUI
git master
Other All
: Normal normal
: ---
Assigned To: Morten Welinder
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2007-11-26 12:43 UTC by sum1
Modified: 2007-11-27 14:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (4.89 KB, patch)
2007-11-26 15:47 UTC, Morten Welinder 		accepted-commit_now Details | Review

Description sum1 2007-11-26 12:43:01 UTC 
Version: r16203
OS: Ubuntu Gutsy

This bug is similar to the two problems described in Bug 496304.

Steps to reproduce:
- Run Gnumeric
- Type 1 into A1 and press enter
- Edit > Sheet > Manage Sheets
- Hide and change the direction of Sheet1 (the direction change makes the bug easier to see)
- Press OK
- Edit > Find
- Type 1 into the Search for field
- Press Find
- Notice that Sheet1 has been focused in the background (the direction of Sheet2 seems to change)
Comment 1 Morten Welinder 2007-11-26 15:22:54 UTC 
Yup similar.

We should not search the deep-deep-undercover sheets.  (No gui to create those
anyway.)

We could avoid searching the hidden sheets, but that will not fix this bug
as the search dialog is not modal.
Comment 2 Morten Welinder 2007-11-26 15:47:39 UTC 
Created attachment 99667 [details] [review]
Patch
Comment 3 Morten Welinder 2007-11-26 15:48:00 UTC 
Needs review.
Comment 4 Andreas J. Guelzow 2007-11-27 01:15:00 UTC 
This patch doesn't look complete: Moving GnmSheetVisibility into gnumeric.h should probably go along with deleting it from sheet.h.

We are still going to search on hidden sheets?
Comment 5 Morten Welinder 2007-11-27 02:32:54 UTC 
Sorry, that is incomplete.  Just pretend the enum got deleted from sheet.h

> We are still going to search on hidden sheets?

I think so.  Later I might add a checkbox on the Advanced tab for that.
Comment 6 Andreas J. Guelzow 2007-11-27 08:25:00 UTC 
looks good to me.
Comment 7 Morten Welinder 2007-11-27 14:09:15 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.