GNOME Bugzilla – Bug 496250
WARNING **: Unknown color when exporting to xls
Last modified: 2018-05-03 14:59:15 UTC
Version: r16116 OS: Ubuntu Gutsy Steps to reproduce: - From gnumeric/src, convert chart-tests-excel.xlsx to Excel format: ./ssconvert ../samples/excel12/chart-tests-excel.xlsx /tmp/foo.xls Relevant console output (warnings and repeated criticals ignored): ** (/home/s/cvs/gnumeric/src/.libs/lt-ssconvert:11426): CRITICAL **: gnm_go_data_get_expr: assertion `dep != NULL' failed ** (/home/s/cvs/gnumeric/src/.libs/lt-ssconvert:11426): CRITICAL **: gnm_expr_top_get_range: assertion `IS_GNM_EXPR_TOP (texpr)' failed ** (/home/s/cvs/gnumeric/src/.libs/lt-ssconvert:11426): CRITICAL **: gnm_expr_top_get_constant: assertion `IS_GNM_EXPR_TOP (texpr)' failed
I see this too.
This looks graph related.
+ Trace 177334
xlsx importe seems to put titles and labels in GODataScalarStr, while xls exporter assumes they are GnmGODataScalar instances.
Created attachment 99008 [details] [review] Proposed patch
Comment on attachment 99008 [details] [review] Proposed patch The patch will work. We'd be better off going the other way, and making xls export more flexible. It's not unreasonable to assume people would put the simple data types in there.
Any objections to this?
hmm, it is of course possible to make xls export more flexible, but xlsx should still not use GODataScalarStr. In my opinion, gnumeric should always use GnmGOData to be more consistent.
Created attachment 109106 [details] [review] ms-chart.c patch Seems I (or someone else) commited the first patch: 2008-03-07 Jean Brefort <jean.brefort@normalesup.org> * xlsx-read.c: (xlsx_chart_text): create GnmGOData instead of GOData, (xlsx_axis_cleanup): do not unref a non deletable axis. Anyway, this one fixes the issue the other way (I just do not like it).
Jean #7 : why a preference for GnmGOData ?
It might refer to the contents of a cell, isn't it enough?
Since the criticals were fixed and nobody seemed sufficiently interested in changing the way it was fixed I was going to close this report, but running the command that started it out yields lots of warnings: [aguelzow@kirkman ~/git/gnumeric]$ jhbuild run ssconvert ./samples/excel12/chart-tests-excel.xlsx /tmp/foo.xls Using exporter Gnumeric_Excel:excel_biff8 ** (ssconvert:31624): WARNING **: EXCEL : unknown widths for font 'Nimbus Sans L', guessing ** (ssconvert:31624): WARNING **: Unknown color (ffce00), converting it to black ** (ssconvert:31624): WARNING **: Unknown color (ffce00), converting it to black ** (ssconvert:31624): WARNING **: Unknown color (ffffce), converting it to black ** (ssconvert:31624): WARNING **: Unknown color (ffffce), converting it to black ** (ssconvert:31624): WARNING **: Unknown color (ceffff), converting it to black and many more
We still have the colour complaints but it looks like we're just hitting a palette size limit in xls. That's just too bad. --> Closing. (As fixed because the important parts really were fixed long ago.)