After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 492181 - No support for %genre% to be specified in /app/banshee/Library
No support for %genre% to be specified in /app/banshee/Library
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Importing
1.0.0
Other All
: Normal normal
: 1.4
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-10-31 21:50 UTC by Rizwan Sarwar
Modified: 2008-07-30 20:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add %genre% support for meta data (1.37 KB, patch)
2007-10-31 22:03 UTC, Rizwan Sarwar
none Details | Review
Add the %genre% conversion to Banshee's file name pattern matching (2.52 KB, patch)
2008-06-29 19:42 UTC, Brian Teague
none Details | Review
Add the %genre% to Banshee's file name pattern matching (4.12 KB, patch)
2008-07-28 20:25 UTC, Brian Teague
committed Details | Review

Description Rizwan Sarwar 2007-10-31 21:50:34 UTC
Banshee does not support %genre% to be specified in file or folder pattern in /app/banshee/Library. A little modification to code fixes this and adds support for %genre%.
Comment 1 Rizwan Sarwar 2007-10-31 22:03:21 UTC
Created attachment 98283 [details] [review]
add %genre% support for meta data

This will fix the issue, copy the file to banshee source directory and issue patch -p0 < genre.patch and then compile.
Comment 2 Brian Teague 2008-06-29 19:42:13 UTC
Created attachment 113640 [details] [review]
Add the %genre% conversion to Banshee's file name pattern matching

The above patch didn't compile for me: I had to add a method to the interface ITrackInfo.
Comment 3 Brian Teague 2008-06-29 19:43:50 UTC
Forgot to note, the above patch is against ver. 1.0.0.  Reporter, maybe you could update the "Version" field on this bug?
Comment 4 Bertrand Lorentz 2008-07-02 15:01:57 UTC
Updating version and attachment status.
Comment 5 Bertrand Lorentz 2008-07-21 21:46:54 UTC
The patch looks good !
You might want also to update the corresponding description in src/Core/Banshee.Core/Banshee.Configuration.Schema/LibrarySchema.cs

In the future, please produce patches from the toplevel directory of the banshee source tree. Have a look at http://banshee-project.org/contribute/write-code/ for more info.
Comment 6 Brian Teague 2008-07-28 20:25:00 UTC
Created attachment 115448 [details] [review]
Add the %genre% to Banshee's file name pattern matching

Re-spin the above patch with input from Bertrand Lorentz.  Patch is now against svn HEAD.
Comment 7 Bertrand Lorentz 2008-07-30 19:56:48 UTC
Looks good for me, and works !
Comment 8 Gabriel Burt 2008-07-30 20:02:48 UTC
Looks good to me too, go ahead and commit this, Bertrand.
Comment 9 Bertrand Lorentz 2008-07-30 20:15:53 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.

And thanks for the patch !