After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 492111 - Doesn't rotate pictures while importing
Doesn't rotate pictures while importing
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
2.10.x
Other All
: Normal normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
: 492258 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-10-31 14:40 UTC by Ignacy Gawędzki
Modified: 2007-11-01 11:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to correct that (439 bytes, patch)
2007-10-31 14:41 UTC, Ignacy Gawędzki
none Details | Review

Description Ignacy Gawędzki 2007-10-31 14:40:17 UTC
Please describe the problem:
When using Gthumb to import pictures, it doesn't physically rotate them as it should when the corresponding option is checked.

Steps to reproduce:
1. Take a picture with vertical orientation
2. Import the picture using gthumb --import-photos
3. Check the "Rotate images physically" option


Actual results:
The picture is not rotated physically

Expected results:
The picture to be rotated physically

Does this happen every time?
Yes

Other information:
Here is a patch:

--- gthumb/src/dlg-photo-importer.c     (revision 2034)
+++ gthumb/src/dlg-photo-importer.c     (working copy)
@@ -1468,7 +1468,7 @@
 
                fd = file_data_new (uri, NULL);
                file_data_update (fd);
-               transform = read_orientation_field (fd->path);
+               transform = read_orientation_field (get_file_path_from_uri (fd->path));
                if (image_is_jpeg (uri))
                        success = apply_transformation_jpeg (fd, transform, JPEG_MCU_ACTION_DONT_TRIM, NULL);
                else
Comment 1 Ignacy Gawędzki 2007-10-31 14:41:16 UTC
Created attachment 98248 [details] [review]
Patch to correct that
Comment 2 Michael Chudobiak 2007-10-31 19:34:56 UTC
Thank you for the patch! A slightly-expanded version has been committed to svn:

http://svn.gnome.org/viewvc/gthumb?view=revision&revision=2035

and should appear in 2.10.8.

- Mike
Comment 3 Ignacy Gawędzki 2007-11-01 11:13:51 UTC
*** Bug 492258 has been marked as a duplicate of this bug. ***