GNOME Bugzilla – Bug 489028
Remove annotations of accessible objects in Gecko.py
Last modified: 2008-07-22 19:32:27 UTC
As part of the pyatspi migration, we need to eliminate: * obj.characterOffsetInParent * obj.childrenIndices (obj.unicodeText is now gone)
Created attachment 97631 [details] [review] first attempt at removing obj.characterOffsetInParent According to the Mozilla docs (http://developer.mozilla.org/en/docs/Accessibility:Architecture): (B) To get the offset in the parent text for a given embedded object: 1. QI/QA to IAHyperLink 2. If not successful, then it is not embedded in text, so it's position in parent should be determined just by IA2::indexInParent, which will return it's child offset within the parent 3. otherwise, use IAHyperLink::getStartIndex() to find the index in parent.
Ignore the above for now. It *seemed* to work, but something is wrong.... :-(
Created attachment 97634 [details] [review] the "don't read docs literally" version If the hyperlink interface is not implemented (e.g. in a combo box or a list), we want to return -1. D'oh! Will, does this patch seem correct?
(In reply to comment #3) > Created an attachment (id=97634) [edit] > the "don't read docs literally" version > > If the hyperlink interface is not implemented (e.g. in a combo box or a list), > we want to return -1. D'oh! > > Will, does this patch seem correct? > Yep! Now that the Gecko bug seems to be fixed, this is the much better way to go. Thanks!
Created attachment 97642 [details] [review] remove obj.childrenIndices Will please review.
Looks good. Thanks!
Both committed. Closing as FIXED.