GNOME Bugzilla – Bug 488213
Evolution locks when displaying e-mail with large tiff drawing attached
Last modified: 2011-12-16 23:22:03 UTC
Forwarding from a downstream bug report: https://bugzilla.redhat.com/show_bug.cgi?id=207648 Description of problem: A colleague sent me an e-mail with two large tiff files attached. One was 13544x9576 pixels, filesize only 182 kB, the other slightly smaller. upon trying to display this message, evolution starts using 100% cpu time. Version-Release number of selected component (if applicable): evolution-2.6.3-1.fc5.5 How reproducible: Open e-mail with huge (in pixels) tif file Steps to Reproduce: 1. 2. 3. Actual results: Evolution starts using 100% CPU Expected results: Mail displayed, images not visible --------------------------------------------------------------------- There is a test image in https://bugzilla.redhat.com/show_bug.cgi?id=207648#c3 I investigated a bit, and even the problem isn't in evolution itself, but in gdk_pixbuf_scale_simple, I will provide a patch with an enhancement.
Created attachment 97472 [details] [review] proposed evo patch for evolution; I added there a global function for scaling pixbufs, which uses gnome_thumbnail_scale_down_pixbuf if HAVE_LIBGNOMEUI_GNOME_THUMBNAIL_H, otherwise do things as before, which means with gdk_pixbuf_scale_simple which is much much slower for such big images. This is a reason why we should clone this bug against gdk, I think.
yepp, libgnome must die, die, die! ;-) http://live.gnome.org/LibgnomeMustDie
Milan, did you file a bug against gdk-pixbuf yet?
Bastien, not yet, but I was going to move this bug to gtk+, so changing product/component right now.
Milan, mean time you can commit this patch to Evolution.
Patch committed to Evolution's trunk. Committed revision 34800. Just one note, it differs a bit in the body of new e-util/e-icon-factory.c: e_icon_factory_pixbuf_scale, because gnome_thumbnail_scale_down_pixbuf can scale only down, so I added there a check for this (thus it will not crash). Bastien, do you want to file a separate bug for gtk+ so it will not show the patch icon in the bug list?
(In reply to comment #6) <snip> > Bastien, do you want to file a separate bug for gtk+ so it will not show the > patch icon in the bug list? This bug is already against gtk+, so we can leave it as-is :)
Hi there, any update on this? You know, the Gnome3 is coming. Added the related Evolution bug to dependency.
(In reply to comment #8) > Hi there, any update on this? You know, the Gnome3 is coming. Added the related > Evolution bug to dependency. There's no gdk-pixbuf patch in this bug, so I wouldn't expect anyone to say anything one way or the other.
*** This bug has been marked as a duplicate of bug 666391 ***