GNOME Bugzilla – Bug 486970
Where Am I should let you know you are in a toolbar
Last modified: 2008-07-22 19:32:52 UTC
Steps to reproduce: 1) Run the Application main window demo of gtk-demo 2) Do a basic "Where Am I" via KP_Enter when you're in the toolbar 3) Orca should let you know you're in a toolbar. Mike, the exact spot where the rolename of toolbar should be presented needs to be spec'd. Please specify where it should be.
Mike, just added your name to the summary to request the spec Will asked for. Thanks!
Something else which (I think) it would be helpful to spec out is exactly when we should check to see if we're in a toolbar. I believe the majority of the controls we handle in Where Am I could have an ancestor that's a toolbar. Should we just always check the hierarchy?
(In reply to comment #2) > Something else which (I think) it would be helpful to spec out is exactly when > we should check to see if we're in a toolbar. I believe the majority of the > controls we handle in Where Am I could have an ancestor that's a toolbar. > Should we just always check the hierarchy? As long as it remains isolated to Where Am I, we probably should just always check the hierarchy.
Created attachment 100130 [details] [review] possible solution (In reply to comment #3) > As long as it remains isolated to Where Am I, we probably should just always > check the hierarchy. Okie dokie. This patch does that. I went ahead and took a guess that we'd want to announce the toolbar first and then the object with focus (in the case of the bug report, the Open button). This patch also optimistically tries to get the label and/or name of the toolbar that contains the locusOfFocus. Unfortunately, toolbars seem to be rather anonymous creatures. Thus with this patch we say "toolbar, open button." But it's not for a lack of trying.... :-) Mike in addition to your feedback and any changes you would like to see in terms of this toolbar patch, I noticed that here, too, we've got the pregnant pause thang going on between "open" and "button". If it sounds funny to you as well, perhaps it's worth opening a bug to eliminate pauses between the names of objects and their roles and adjusting all of our test assertions accordingly? Let me know. Thanks!
The WhereAmI information presented here sounds good to me. With Espeak I'm not bothered by the pauses but I don't mind if you want to remove them.
Created attachment 100148 [details] [review] updated test assertions; left pauses If I'm the only one bothered by the pause, might as well leave it as is. <smile> Will, please review.
(In reply to comment #6) > Created an attachment (id=100148) [edit] > updated test assertions; left pauses > > If I'm the only one bothered by the pause, might as well leave it as is. > <smile> > > Will, please review. > This looks good. If I were to change anything, it would be to add a strip to get rid of the ' ' in front of 'toolbar' since that ' ' looks odd. + text = self._getObjLabelAndName(obj) + " " + \ + rolenames.getSpeechForRoleName(obj) + utterances.append(text.strip()) Other than that, I say commit and close this bug.
Created attachment 100340 [details] [review] stripped the ' ' Sounds good. The ' ' is stripped; the test updated accordingly. Patch committed.
looks good
Thanks. Closing as FIXED.