After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 484989 - memleak, not unrefed caps for gstbasertppayload.c
memleak, not unrefed caps for gstbasertppayload.c
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-10-09 09:25 UTC by Laurent Glayal
Modified: 2007-10-09 09:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Laurent Glayal 2007-10-09 09:25:27 UTC 
Following caps are not unreffed :

506 : 	  	  	 temp = gst_caps_intersect (srccaps, peercaps);

Patch :
Index: gstbasertppayload.c
===================================================================
RCS file: /cvs/gstreamer/gst-plugins-base/gst-libs/gst/rtp/gstbasertppayload.c,v
retrieving revision 1.30
diff -u -r1.30 gstbasertppayload.c
--- gstbasertppayload.c 19 Sep 2007 15:55:08 -0000      1.30
+++ gstbasertppayload.c 9 Oct 2007 09:18:51 -0000
@@ -573,6 +573,8 @@

     gst_structure_foreach (s, (GstStructureForeachFunc) copy_fixed, d);

+    gst_caps_unref(temp);
+
     GST_DEBUG_OBJECT (payload, "with peer caps: %" GST_PTR_FORMAT, srccaps);
   }
Comment 1 Wim Taymans 2007-10-09 09:57:13 UTC 
        Patch by: Laurent Glayal <spglegle at yahoo dot fr>

        * gst-libs/gst/rtp/gstbasertppayload.c: (copy_fixed),
        (gst_basertppayload_set_outcaps):
        Fix caps memleak. Fixes #484989.