After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 483382 - Segfault when closing search dialog with ESC
Segfault when closing search dialog with ESC
Status: RESOLVED FIXED
Product: gconf-editor
Classification: Applications
Component: general
unspecified
Other Linux
: Normal major
: ---
Assigned To: Gconf Editor Maintainers
Gconf Editor Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-10-04 14:36 UTC by Sebastian Dröge (slomo)
Modified: 2008-02-05 16:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gconf-search-crash.diff (535 bytes, patch)
2007-10-04 14:36 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2007-10-04 14:36:06 UTC 
Hi,
gconf-editor 2.20.0 (which is not yet tagged in SVN btw...) crashes when closing the search dialog with ESC after one has search for something.

Attached patch fixes this at least for me, problem seems to be that there are two weak pointers on that address, one as seen in the patch and one from gconf-editor-window.c. The one that is removed with this patch doesn't make much sense anyway IMHO.

Ok to commit?

Bye
Comment 1 Sebastian Dröge (slomo) 2007-10-04 14:36:37 UTC 
Created attachment 96639 [details] [review]
gconf-search-crash.diff


Btw, Debian bug:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=445259
Comment 2 Sebastian Dröge (slomo) 2007-10-04 14:40:35 UTC 
Just for the record, the segfault happens after gtk_widget_destroy() in gconf_search_dialog_response() is called (a second time for the single ESC btw and it's only called once after my patch).

The backtrace isn't that useful though...

Program received signal SIGSEGV, Segmentation fault.

+ Trace 167721

Thread NaN (LWP 21593)

  • #0 gtk_widget_event_internal
    at /build/buildd/gtk+2.0-2.12.0/gtk/gtkwidget.c line 4677
  • #1 IA__gtk_main_do_event
    at /build/buildd/gtk+2.0-2.12.0/gtk/gtkmain.c line 1471
  • #2 gtk_dialog_close
    at /build/buildd/gtk+2.0-2.12.0/gtk/gtkdialog.c line 441
  • #3 g_cclosure_marshal_VOID__VOID
    from /usr/lib/libgobject-2.0.so.0
  • #4 ??
    from /usr/lib/libgobject-2.0.so.0
  • #5 ??
  • #6 ??
  • #7 ??
  • #8 ??
  • #9 ??
  • #10 ??
    at /build/buildd/gtk+2.0-2.12.0/gtk/gtkdialog.c line 112
  • #11 ??
  • #12 ??
    from /usr/lib/libgobject-2.0.so.0
  • #13 gtk_menu_item_get_type
  • #14 ??
  • #15 ??
  • #16 g_closure_invoke
    from /usr/lib/libgobject-2.0.so.0 






Comment 3


Sebastian Dröge (slomo)





          2008-02-05 16:43:46 UTC
        



Ok, fixed in trunk...