After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 480883 - User can pan right in braille indefinitely at the end of a web page
User can pan right in braille indefinitely at the end of a web page
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: 2.28.0
Assigned To: Willie Walker
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-09-27 09:54 UTC by rudolf.weeber
Modified: 2009-11-09 21:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
First pass at getting the pan left/right keys working in document content (5.07 KB, patch)
2009-07-20 21:01 UTC, Willie Walker
committed Details | Review
Patch to resolve the indefinite panning problem (2.84 KB, patch)
2009-08-03 18:33 UTC, Willie Walker
committed Details | Review

Description rudolf.weeber 2007-09-27 09:54:48 UTC
Hi,
in FF3, I found the following problems
* The "home" and "end"-keys dont work, which is bad for long lines
* Jumping to next/prev word should work with rigght ctrl as well (for those who read braille with the left hand).
Panning the Braille-Display by one display length (via keys on the display) in many cases does not work across line breaks. This way, when reading a long text, you have to switch between braille display keys and cursor keys.

Thanks in advance,
Cheers, Rudolf
Comment 1 Willie Walker 2007-10-02 13:00:49 UTC
Thank you for logging this bug.  We definitely appreciate your feedback and input.  We are tracking a related Home/End problem in bug 414762 - Control Home/End, Up/Down Arrow don't always work in Firefox.  

Can you describe more about where the "Home" and "End" keys are not working for you so we can be sure we are looking at the same problem?  For example, which URL are you looking at, where is the caret before you press "Home" or "End", where does it end up after you press "Home" or "End", and where did you expect it to end up?

Can you also please provide similar descriptions regarding navigation via the Braille display?
Comment 2 rudolf.weeber 2007-11-04 10:23:51 UTC
Hi,
Maybe, I just found out something: I always assumed, that pressing the end key should place the caret at the end of the current line. But FF3 seems to go to the end of the document - without repositioning the orca caret. Thats why I thought, nothing happened. If this actually is the way it is, it would be nice
* if orca's caret reacted to the change of position in FF
* if there were keys for going to beginning/end of line.

The panning probem and the richt-control-problem can also be found on this page:
When reading trough the text on the right hand side, using thw window-richt and window-left keys on the braille display only work within a line. To go to the next line, you need to press cursor-down. this is not so good, because when reading through a text with the braille display, you cannot tell - and do not care - wether you are at an end of a line.

When pressing ctrl+right/left to go to next/prev word, it works fine with the left ctrl key, but the richt ctrl key is just ignored. Being able to use the right ctrl key would be nice for people - like me :-) - who read braille iwth the left hand.

The page I tried is:
www-neu.faveve.uni-stuttgart.de/node/5
But I found the same problem on other pages.

Cheers, 
Rudolf
Comment 3 Willie Walker 2007-11-06 14:03:09 UTC
(In reply to comment #2)
> Maybe, I just found out something: I always assumed, that pressing the end key
> should place the caret at the end of the current line. But FF3 seems to go to
> the end of the document - without repositioning the orca caret.

Strange.  I think the problem here is that caret navigation has not been enabled in FF.  To enable caret navigation, press F7.  Once you press F7, a dialog should appear that discusses the enabling of caret navigation.  Press the "Yes" button and caret navigation will be enabled.  

When caret navigation is enabled, the Home/End keys should behave as you expect: on their own, they go to the beginning/end of the line, and go to the beginning/end of the page when pressed in conjunction with the Control key.

> The panning probem and the richt-control-problem can also be found on this
> page:
> When reading trough the text on the right hand side, using thw window-richt and
> window-left keys on the braille display only work within a line. To go to the
> next line, you need to press cursor-down. this is not so good, because when
> reading through a text with the braille display, you cannot tell - and do not
> care - wether you are at an end of a line.

We definitely could do a better job with navigating web content from the braille display alone.

In any case, please try enabling caret navigation via F7 and we can move forward from there.
Comment 4 Willie Walker 2008-01-06 16:59:49 UTC
Hi Rudolf:  Does this problem still exist for you?  If so, have you tried enabling caret navigation via F7?
Comment 5 rudolf.weeber 2008-02-22 07:37:29 UTC
Hi,
I'll try to give a more detailed report. However, I cannot always tell, where I'm ending up after pressing the home/end keys.
I used live.gnome.org/Orca as test page.
I went to the line
"Pleas join and participate on the orca mailing list..."

I enabled caret navigation.
I then used te richt-key to move a few characters into the line.
If I then press the home key, about 3/4 of all times, nothing at all happens. That does not change by pressing it again many times.
After moving the cursor again, there is a new chance...
In the 1/4 of cases, where something does happen, it works correctly.
One small exception: In numbered lists (like the table of contents on the wik page), the home key moves to the first letter AFTER the number instead of to the beginning of the line.


When pressing end:
* Alwasy something happens
* Braile is never updated, when the cursor is moved outside the current window
* On the line quoted above, the cursor jumps behind the "Orca mailng list" link instead of to the end of the line.
* On the line "Orca is a flexible, ...", where there are no links, the cursor moves behind the last character of the line. As I said, braille is not updated, but the cursor is also not visible when panning the braille diaply there.
* The same occurs on lines, where there is a role name at the end.
  To try it, 
  * go to "Audio Guides H1"
  * Press end
    the cursor vanishes from the braille diaplay
  * Press left-key once
    The cursor is now on the last 's" of "audio guides"

The probelm with the vanishing cursor also occurs when walking around line breaks using the left/right keys.
Got to the line "speech synthesis, braille, and magnification..."
and use the left key to wrap around the line break.
At the first press, the cursor jumps behind the end of the previous line, but the braille display jumps to the beginning of the previous line. 
At the second press, the cursor is at the last character of the previous line and the braille display is positioned correctly.
The same happens on the way back using the right key.

I think, that maybe there are two problems:
* The hom/end key thing
* The "braille display is positioned incorrectly and cursor vanishes if cursor is behind last char" thing


These tests were done with todays orca and a firefox built last weekend.

I hope, this report helps in tracking the problem down. Unfortunately I don't quite recognize a system in some of the behavior. so I can't be more precise.

Cheers, Rudolf

Comment 6 Willie Walker 2008-03-11 14:06:31 UTC
First coarse pass at GNOME 2.24 planning.
Comment 7 Joanmarie Diggs (IRC: joanie) 2008-05-27 20:17:37 UTC
I'm breaking this into two bugs because they're two bugs. :-)  Bug 535149 is for overriding Home and End.

Mike, we need your input on the braille part of this bug.  Thanks!
Comment 8 Mike Pedersen 2008-06-10 18:47:27 UTC
What seems to be the problem here is that the first press of the panning key is just not correct.  When rapping occures the cursor should reflect the new position 
Comment 9 Willie Walker 2009-01-21 15:55:17 UTC
Reassigning this to Mike for his comments and for possible inclusion into 2.26.0.
Comment 10 Mike Pedersen 2009-02-23 20:28:59 UTC
Is more info still required from me on this one?  The issue in comment 8 still seems to exist.  
Comment 11 Willie Walker 2009-07-20 21:01:29 UTC
Created attachment 138854 [details] [review]
First pass at getting the pan left/right keys working in document content

Here's a first pass at getting the pan left/right keys to walk you through document content. Please give it a test in both Gecko and Thunderbird since it touches the core Gecko script.

I see at least one problem with it right now, which is that when we hit the last line in a document, repeated presses of the "pan right" button on the braille display will keep cycling you through the last line.
Comment 12 Willie Walker 2009-07-22 15:40:24 UTC
(In reply to comment #11)
> I see at least one problem with it right now, which is that when we hit the
> last line in a document, repeated presses of the "pan right" button on the
> braille display will keep cycling you through the last line.

Even with this issue, I think the situation is much better than what we currently have.  Mike, please test.
Comment 13 Mike Pedersen 2009-07-25 04:55:41 UTC
Even with the known issue this is a nice improvement.  
Comment 14 Willie Walker 2009-07-27 13:52:52 UTC
Patch committed for 2.27.5 after merging with the mouse over changes.  Retitling this to reflect the remaining issue: when we hit the last line in a document, repeated presses of the "pan right" button on the braille display will keep cycling you through the last line.
Comment 15 Willie Walker 2009-08-03 17:44:28 UTC
(In reply to comment #14)
> Patch committed for 2.27.5 after merging with the mouse over changes. 
> Retitling this to reflect the remaining issue: when we hit the last line in a
> document, repeated presses of the "pan right" button on the braille display
> will keep cycling you through the last line.

The patch that was committed just calls self.goNextLine(inputEvent) and then pans left to make sure the beginning of the line is going.  If self.goNextLine can be modified to return a boolean saying whether it does something or not, we can only pan left when necessary.

Comment 16 Willie Walker 2009-08-03 18:33:28 UTC
Created attachment 139809 [details] [review]
Patch to resolve the indefinite panning problem